Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude smart transaction status page from rate limiting #30537

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+3 −0
Open

fix: exclude smart transaction status page from rate limiting #30537

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
183e953
fix: exclude smart transaction status page from rate limiting
httpJunkie Feb 24, 2025
8a9a42a
Merge branch 'main' into fix/sequential-tx-popup-state
httpJunkie Feb 24, 2025
646d34e
Merge branch 'main' into fix/sequential-tx-popup-state
httpJunkie Feb 24, 2025
6e29672
Merge branch 'main' into fix/sequential-tx-popup-state
httpJunkie Feb 25, 2025
202e496
feat: add SMART_TRANSACTION_CONFIRMATION_TYPES rather than a string.
httpJunkie Feb 25, 2025
56596a0
fix: import order
httpJunkie Feb 25, 2025
aab8455
fix: remove extra import and consolidate into existing import
httpJunkie Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/scripts/metamask-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@
SnapInterfaceControllerInit,
SnapsRegistryInit,
} from './controller-init/snaps';
import { SMART_TRANSACTION_CONFIRMATION_TYPES } from '../shared/constants/app';

Check failure on line 376 in app/scripts/metamask-controller.js

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

`../shared/constants/app` import should occur before import of `./lib/transaction/metrics`

Check failure on line 376 in app/scripts/metamask-controller.js

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

Unable to resolve path to module '../shared/constants/app'

const { TRIGGER_TYPES } = NotificationServicesController.Constants;
export const METAMASK_CONTROLLER_EVENTS = {
Expand Down Expand Up @@ -522,6 +523,8 @@
ApprovalType.WatchAsset,
ApprovalType.EthGetEncryptionPublicKey,
ApprovalType.EthDecrypt,
// Exclude Smart TX Status Page from rate limiting to allow sequential transactions
SMART_TRANSACTION_CONFIRMATION_TYPES.showSmartTransactionStatusPage,
],
});

Expand Down
Loading