-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (cherry-pick): Handle nullish value in alphanumeric sort #30534
Merged
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Fixes a bug reported where alphaNumeric sort was breaking on `.localeCompare` method, where it was comparing a `null` value. <img width="677" alt="Screenshot 2025-02-21 at 8 36 07 AM" src="https://github.com/user-attachments/assets/fd66c259-a43e-47d6-9854-36d3b456e925" /> [](https://codespaces.new/MetaMask/metamask-extension/pull/30500?quickstart=1) ## **Related issues** Fixes: #30496 ## **Manual testing steps** To replicate the bug 1. checkout main 2. In `token-list` hard code one of the values in `filteredAssets` to have a `symbol` of `null`. This is the value being passed to the alphaNumeric sort handler, and tokens should be filtered by that value when "Sort by alphanumeric" sort filter is toggled on. 3. App will break with the error posted above. To check fix 1. Checkout this branch 2. In `token-list` hard code one of the values in `filteredAssets` to have a `symbol` of `null`. This is the value being passed to the alphaNumeric sort handler, and tokens should be filtered by that value when "Sort by alphanumeric" sort filter is toggled on. 3. Token list should render, app should not break. The token will appear at the top of the list, as an empty string is considered > than an actual value. ## **Screenshots/Recordings** ### **After** The duplicated `1Inch` token is the value I hardcoded for testing purposes. <img width="359" alt="Screenshot 2025-02-21 at 8 47 34 AM" src="https://github.com/user-attachments/assets/d6f7f6f6-a807-4a18-8847-295d13b90684" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [0992127]
Page Load Metrics (1752 ± 64 ms)
|
danjm
approved these changes
Feb 24, 2025
No release label on PR. Adding release label release-12.13.0 on PR, as PR was cherry-picked in branch 12.13.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks 2c72002 to v12.13.0.
Description
Fixes a bug reported where alphaNumeric sort was breaking on
.localeCompare
method, where it was comparing anull
value.Related issues
Fixes: #30496
Manual testing steps
To replicate the bug
token-list
hard code one of the values infilteredAssets
to have asymbol
ofnull
. This is the value being passed to the alphaNumeric sort handler, and tokens should be filtered by that value when "Sort by alphanumeric" sort filter is toggled on.To check fix
token-list
hard code one of the values infilteredAssets
to have asymbol
ofnull
. This is the value being passed to the alphaNumeric sort handler, and tokens should be filtered by that value when "Sort by alphanumeric" sort filter is toggled on.Screenshots/Recordings
After
The duplicated
1Inch
token is the value I hardcoded for testing purposes.Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist