Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump notifications services controller to v1.0.0 #30532

Open
wants to merge 2 commits into from

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 24, 2025

Description

Bumps notification services to v1.0.0.

Includes quite a bit of under the hood changes, but most changes were to support mobile changes.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Attempt full notifications flow

  1. Enable/Disable Notifications
  2. Enable/Disable Account Notifications
  3. Enable/Disable Feature Announcements
  4. Create a transaction to perform a push notification and notification.

Screenshots/Recordings

Demo Full Notifications Flow:
https://www.loom.com/share/453aead2dc504de8a7d0e3d8fa13c639?sid=7fe129af-a02d-4800-9fc0-bd1f0b7ff43f

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 24, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.4 MB metamaskbot

View full report↗︎

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review February 24, 2025 16:26
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the upgrade/bump-notification-services-controller branch from c62dfd2 to 0c19b11 Compare February 24, 2025 17:48
@metamaskbot
Copy link
Collaborator

Builds ready [0c19b11]
Page Load Metrics (1618 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34719651556310149
domContentLoaded13231955158114067
load13871965161814268
domInteractive24104422512
backgroundConnect1188412512
firstReactRender1484352612
getState56415168
initialActions01000
loadScripts9431492116212359
setupStore76815157
uiStartup15922235184415976
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 142.92 KiB (2.53%)
  • ui: 0 Bytes (0.00%)
  • common: -139.88 KiB (-1.63%)

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Feb 25, 2025
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants