feat(snap-keyring): handle displayAccountNameSuggestion flag

[danroc]

Description

This PR handles the displayAccountNameSuggestion flag that can be set by pre-installed Snaps in the accountCreated event.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/829

Manual testing steps

1. Update a pre-installed Snap to set displayAccountNameSuggestion to false:

   diff --git a/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts 
   b/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   index 27238e7..6edabc7 100644
   --- a/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   +++ b/packages/snap/src/core/handlers/onKeyringRequest/Keyring.ts
   @@ -224,7 +224,8 @@ export class SolanaKeyring implements Keyring {
             * and the snaps sdk does not allow extra properties.
             */
            account: keyringAccount,
   -        accountNameSuggestion: `Solana Account ${index + 1}`,
   +        accountNameSuggestion: `Solana Account`,
   +        displayAccountNameSuggestion: false,
          });
   
          return keyringAccount;

2. Build the Snap and add a resolution in the extension's package.json:

   "@metamask/solana-wallet-snap@^1.2.0": "file:../snap-solana-wallet/packages/snap"
   

3. Start the extension: yarn && yarn start:flask

4. Create an account

5. The account name dialog should not be shown

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[ccharly]

For future reviewers: The displayConfirmation was wrongly set to false. Now with this change, all pre-installed Snaps will have to send this flag while emitting the AccountCreated event.

[danroc]

Note: The change mentioned in the comment above was reverted because it requires a change in snap-watch-only. It will be handled in a separate PR once the Snap is updated.

[metamaskbot]

Builds ready [d05e715]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1526 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	304	1711	1456	282	135
		domContentLoaded	1311	1861	1507	124	60
		load	1318	1865	1526	124	59
		domInteractive	17	72	32	16	8
		backgroundConnect	8	53	25	16	7
		firstReactRender	13	75	25	20	10
		getState	4	44	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	951	1394	1121	106	51
		setupStore	7	49	10	9	4
		uiStartup	1509	2159	1733	148	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 598 Bytes (0.01%)
• ui: 52 Bytes (0.00%)
• common: 1.6 MiB (18.99%)

[ccharly]

Just to complement my approval, here's a video of my testing:

Screen.Recording.2025-02-25.at.10.26.30.mov