Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add snap_experimentalProviderRequest to unrestricted methods #30525

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 24, 2025

Description

This adds snap_experimentalProviderRequest to the list of unrestricted methods.

Note

This method is experimental, and will be removed in a future update.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Feb 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [dfdcb97]
Page Load Metrics (1703 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint145021211700215103
domContentLoaded14081999166418890
load14532071170319091
domInteractive248037157
backgroundConnect9127373014
firstReactRender1478302412
getState55816189
initialActions01000
loadScripts10371546124314971
setupStore766202110
uiStartup16502330194920699
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 35 Bytes (0.00%)

@Mrtenz Mrtenz changed the title Add snap_experimentalProviderRequest to unrestricted methods fix: Add snap_experimentalProviderRequest to unrestricted methods Feb 24, 2025
@Mrtenz Mrtenz marked this pull request as ready for review February 24, 2025 20:55
@metamaskbot
Copy link
Collaborator

Builds ready [c651ca3]
Page Load Metrics (1788 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28121171704356171
domContentLoaded14762108174414871
load15622123178813565
domInteractive2498482110
backgroundConnect1194442612
firstReactRender14582194
getState76222199
initialActions01000
loadScripts10641588130211857
setupStore875262311
uiStartup17782448202415976
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 270 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 35 Bytes (0.00%)

@Mrtenz Mrtenz added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 2fffd78 Feb 25, 2025
79 checks passed
@Mrtenz Mrtenz deleted the mrtenz/unblock-snap_experimentalProviderRequest branch February 25, 2025 11:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants