feat: token approvals from nested transactions in simulation details #30511
+1,435
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily add mock simulation data. Add useBatchApproveTokenSimulation hook. Add BatchSimulationDetails component.
Remove batch spending cap.
| const { args, name } = transactionDescription ?? {}; | ||
|
|
||
| if ( | ||
| !['approve', 'increaseAllowance', 'setApprovalForAll'].includes(name ?? '') |
There was a problem hiding this comment.
Perhaps we can compare token method names by leveraging the TransactionTypes like we do in determineTransactionType, instead of hardcoding the strings?
There was a problem hiding this comment.
We technically could, but it's coincidence that the types match the names as some of the transaction types for example don't align with any contract methods.
Though I'm not opposed to using a central enum, assuming one exists or we add one.
| @@ -48,7 +67,25 @@ export const BalanceChangeRow: React.FC<{ | |||
| style={{ minWidth: 0 }} | |||
| > | |||
| <Box display={Display.Flex} flexDirection={FlexDirection.Row} gap={1}> | |||
| <AmountPill asset={asset} amount={amount} /> | |||
| {onEdit && ( | |||
There was a problem hiding this comment.
This is a great addition, and directly addresses a pain point recently reported internally. 🔥 See https://consensys.slack.com/archives/C03ETQA9EPK/p1739549199067819
pedronfigueiredo
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decode approvals from nested transaction data and include them in the simulation details.
Specifically:
BatchSimulationDetailscomponent to display simulation details including approvals.useBatchApproveBalanceChangeshook to generate balance changes for approvals.staticRowsproperty toSimulationDetailsto display additional static data.parseApprovalTransactionDatafunction to shared utils to centralise approval data parsing.buildXTransactionDatahelper functions to avoid hardcoding transaction data strings.isApproval,isAllApproval, andisUnlimitedApprovaltoBalanceChangetype.AmountPillto support approval styles and handle unlimited and all.BalanceChangeRowto include edit icon ifonEditprovided in balance change.EditSpendingCapModalto support optionaldataandtoproperties.Note that edit approval will not submit as it is pending an additional ticket to connect to a new method from the
TransactionController.Related issues
Fixes #4283
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist