-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add transaction simulation supported networks global mock #30507
Merged
Gudahtt
merged 4 commits into
main
from
add-transaction-simulation-supported-networks-global-mock
Feb 21, 2025
Merged
fix: Add transaction simulation supported networks global mock #30507
Gudahtt
merged 4 commits into
main
from
add-transaction-simulation-supported-networks-global-mock
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A global mock has been added for the "supported networks" check made as part of the transaction simulations feature. This is triggered by certain types of confirmations (those that support transaction simulations), so it's triggered by a wide variety of E2E tests. Fixes #30490
c130e54
to
333ce37
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
LGTM ! |
DDDDDanica
approved these changes
Feb 21, 2025
seaona
approved these changes
Feb 21, 2025
Builds ready [e05b2c1]
Page Load Metrics (1808 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Missing release label release-12.13.0 on PR. Adding release label release-12.13.0 on PR and removing other release labels(release-12.14.0), as PR was cherry-picked in branch 12.13.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.13.0
Issue or pull request that will be included in release 12.13.0
team-confirmations
Push issues to confirmations team
team-extension-platform
Extension Platform team
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A global mock has been added for the "supported networks" check made as part of the transaction simulations feature. This is triggered by certain types of confirmations (those that support transaction simulations), so it's triggered by a wide variety of E2E tests.
Related issues
Fixes #30490
Manual testing steps
This should resolve the privacy snapshot related errors on CI.
You could also double-check that the mocked response is returned by running an e2e test locally that uses a confirmation that supports transaction simulation, then inspecting the network tab of the service worker dev console while the test is running, and checking the response to the
https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io/networks
callScreenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist