Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add transaction simulation supported networks global mock #30507

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 21, 2025

Description

A global mock has been added for the "supported networks" check made as part of the transaction simulations feature. This is triggered by certain types of confirmations (those that support transaction simulations), so it's triggered by a wide variety of E2E tests.

Open in GitHub Codespaces

Related issues

Fixes #30490

Manual testing steps

This should resolve the privacy snapshot related errors on CI.

You could also double-check that the mocked response is returned by running an e2e test locally that uses a confirmation that supports transaction simulation, then inspecting the network tab of the service worker dev console while the test is running, and checking the response to the https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io/networks call

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added team-extension-platform Extension Platform team team-confirmations Push issues to confirmations team labels Feb 21, 2025
A global mock has been added for the "supported networks" check made as
part of the transaction simulations feature. This is triggered by
certain types of confirmations (those that support transaction
simulations), so it's triggered by a wide variety of E2E tests.

Fixes #30490
@Gudahtt Gudahtt force-pushed the add-transaction-simulation-supported-networks-global-mock branch from c130e54 to 333ce37 Compare February 21, 2025 18:37
@Gudahtt Gudahtt marked this pull request as ready for review February 21, 2025 18:58
@Gudahtt Gudahtt marked this pull request as draft February 21, 2025 19:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Gudahtt Gudahtt marked this pull request as ready for review February 21, 2025 20:14
@DDDDDanica
Copy link
Contributor

LGTM !

@HowardBraham HowardBraham added this pull request to the merge queue Feb 21, 2025
@Gudahtt Gudahtt removed this pull request from the merge queue due to a manual request Feb 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e05b2c1]
Page Load Metrics (1808 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint12021071635490235
domContentLoaded15412314177617986
load15502319180818589
domInteractive25147463115
backgroundConnect127034199
firstReactRender1579372412
getState66624209
initialActions01000
loadScripts11321852133216579
setupStore7531495
uiStartup18052576207119493
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 94 Bytes (0.00%)

@Gudahtt Gudahtt merged commit ff041ab into main Feb 21, 2025
79 checks passed
@Gudahtt Gudahtt deleted the add-transaction-simulation-supported-networks-global-mock branch February 21, 2025 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@metamaskbot metamaskbot added release-12.14.0 Issue or pull request that will be included in release 12.14.0 release-12.13.0 Issue or pull request that will be included in release 12.13.0 and removed release-12.14.0 Issue or pull request that will be included in release 12.14.0 labels Feb 21, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-12.13.0 on PR. Adding release label release-12.13.0 on PR and removing other release labels(release-12.14.0), as PR was cherry-picked in branch 12.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-confirmations Push issues to confirmations team team-extension-platform Extension Platform team team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Sentinel - Unexpected request sent to tx-sentinel-bsc-mainnet.api.cx.metamask.io.
4 participants