Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix attribution generation #30498

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 21, 2025

Description

Attribution generation is currently broken because the root postinstall script uses tsx, but attribution generation uses a focused production-only install that omits development dependencies like tsx. Beyond that, the foundry installation is something we don't want when generating attributions, even if it did work.

The attribution generation script has been updated to unset the root postinstall script prior to installation.

Open in GitHub Codespaces

Related issues

Fixes #30497

Manual testing steps

Run yarn attributions:generate

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt force-pushed the fix-attribution-generation-postinstall-crash branch from be7e769 to 5017aec Compare February 21, 2025 16:38
Copy link
Contributor

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine!

@Gudahtt Gudahtt marked this pull request as ready for review February 21, 2025 17:08
Attribution generation is currently broken because the root
`postinstall` script uses `tsx`, but attribution generation uses a
focused production-only install that omits development dependencies
like `tsx`. Beyond that, the foundry installation is something we don't
want when generating attributions, even if it did work.

The attribution generation script has been updated to unset the root
`postinstall` script prior to installation.
@Gudahtt Gudahtt force-pushed the fix-attribution-generation-postinstall-crash branch from 5f8da2b to 737d74c Compare February 21, 2025 20:28
@Gudahtt Gudahtt enabled auto-merge February 21, 2025 20:28
@Gudahtt Gudahtt added this pull request to the merge queue Feb 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [737d74c]
Page Load Metrics (1671 ± 131 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint73719551570249120
domContentLoaded139026011640268129
load140926131671272131
domInteractive22301506029
backgroundConnect979342512
firstReactRender1473332411
getState65115147
initialActions00000
loadScripts100019771225220106
setupStore76414168
uiStartup156127461884273131
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 3e51501 Feb 21, 2025
79 checks passed
@Gudahtt Gudahtt deleted the fix-attribution-generation-postinstall-crash branch February 21, 2025 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Attribution generation fails
4 participants