Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @metamask/multichain #30495

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

ffmcgee725
Copy link
Member

@ffmcgee725 ffmcgee725 commented Feb 21, 2025

We appear to be adding an account to the wallet scope

Image

Resulting in this failing CI for our Multichain Flask PR

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/125517/workflows/abdfdb4f-da74-4cc2-9c2f-cf001817f358/jobs/4559282

we should add it to the wallet:eip155 scope (as currently done), but not just wallet.

The fix involves refactoring core Multichain package so that creating the scopeObjects for each entry, we make sure that in wallet scope string, the accounts property is not populated.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Feb 21, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 298 kB danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 522 kB metamaskbot

View full report↗︎

@metamaskbot
Copy link
Collaborator

❌ Multichain API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

❌ Multichain API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

❌ Multichain API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

❌ Multichain API Spec Test Failed. View the report here.

@ffmcgee725 ffmcgee725 marked this pull request as ready for review February 25, 2025 11:54
@ffmcgee725 ffmcgee725 merged commit 157a555 into jl/caip-multichain-migrate-core Feb 25, 2025
60 of 71 checks passed
@ffmcgee725 ffmcgee725 deleted the jc/fix-api-specs-pipeline branch February 25, 2025 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants