feat: replace experimental add solana account with remote flag #30487

aganglada · 2025-02-21T13:27:58Z

Description

Removes experimental Enable "Add Solana account" setting
Adds remote feature flag fence
Enable feature in flask - dev

Related issues

Fixes:

Manual testing steps

Add MANIFEST_OVERRIDES=.manifest-overrides.json to the .metamaskrc
Create a .manifest-overrides.json file
Add the following content

{
  "_flags": {
    "remoteFeatureFlags": { "addSolanaAccount": true }
  }
}

Build
Modify the value to test both cases (enabled/disabled)

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-21T13:28:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ccharly

Also, we should either remove this selector here:

https://github.com/MetaMask/metamask-extension/blob/SOL-134-extension-replace-experimental-toggle-for-rc-with-remote-flags/ui/selectors/selectors.js#L2704-L2715

OR, we could keep it as and re-use the remote-ff-flag under the hood (I've never really used it, so IDK if that plays well with our selectors?)

ui/selectors/multichain/networks.test.ts

ui/selectors/multichain/networks.ts

metamaskbot · 2025-02-24T09:31:55Z

Builds ready [21a7f01]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1754 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1435	1985	1747	160	77
		domContentLoaded	1424	1966	1716	151	72
		load	1433	1991	1754	151	73
		domInteractive	18	125	44	26	12
		backgroundConnect	11	94	39	24	11
		firstReactRender	14	70	29	19	9
		getState	5	72	23	23	11
		initialActions	0	1	0	0	0
		loadScripts	1029	1500	1279	131	63
		setupStore	8	59	17	16	8
		uiStartup	1678	2298	2004	174	84

Bundle size diffs [🚀 Bundle size reduced!]

background: -47 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -442 Bytes (-0.01%)

metamaskbot · 2025-02-24T12:04:25Z

Builds ready [7991628]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1640 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1442	1967	1639	121	58
		domContentLoaded	1437	1872	1609	108	52
		load	1441	1956	1640	122	59
		domInteractive	24	60	33	9	4
		backgroundConnect	9	84	31	21	10
		firstReactRender	14	75	34	24	11
		getState	4	79	19	22	11
		initialActions	0	1	0	0	0
		loadScripts	1010	1316	1168	86	41
		setupStore	7	68	16	17	8
		uiStartup	1666	2185	1873	132	63

Bundle size diffs [🚀 Bundle size reduced!]

background: -47 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -535 Bytes (-0.01%)

ui/selectors/multichain/networks.ts

ui/selectors/multichain/networks.test.ts

metamaskbot · 2025-02-24T15:07:41Z

Builds ready [79feb37]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1658 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	336	2101	1472	396	190
		domContentLoaded	1397	2420	1627	242	116
		load	1458	2426	1658	236	113
		domInteractive	25	143	45	32	15
		backgroundConnect	8	76	37	23	11
		firstReactRender	14	90	38	27	13
		getState	5	173	21	38	18
		initialActions	0	1	0	0	0
		loadScripts	968	1843	1188	205	98
		setupStore	7	71	14	14	7
		uiStartup	1673	2768	1889	271	130

Bundle size diffs [🚀 Bundle size reduced!]

background: -47 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -303 Bytes (-0.00%)

ui/selectors/multichain/networks.test.ts

DDDDDanica · 2025-02-24T15:40:48Z

The implementation of remote feature flag looks good to me, let me know when you finish resolving other comments 🙏🏻

metamaskbot · 2025-02-24T15:50:47Z

Builds ready [34e27a9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1683 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1422	2005	1678	147	71
		domContentLoaded	1415	1987	1646	147	70
		load	1484	2003	1683	144	69
		domInteractive	24	86	38	16	8
		backgroundConnect	10	70	39	22	10
		firstReactRender	13	75	25	20	9
		getState	5	68	21	24	11
		initialActions	0	1	0	0	0
		loadScripts	1022	1491	1205	123	59
		setupStore	7	59	11	11	5
		uiStartup	1683	2319	1921	164	79

Bundle size diffs [🚀 Bundle size reduced!]

background: -47 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -303 Bytes (-0.00%)

metamaskbot · 2025-02-24T17:08:42Z

Builds ready [29827e9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1847 ± 124 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	295	2486	1483	715	343
		domContentLoaded	1368	2367	1811	251	121
		load	1412	2477	1847	258	124
		domInteractive	24	158	44	30	14
		backgroundConnect	7	104	42	28	13
		firstReactRender	15	75	29	20	10
		getState	4	51	13	11	5
		initialActions	0	1	0	0	0
		loadScripts	971	1870	1337	219	105
		setupStore	8	71	24	22	11
		uiStartup	1614	2808	2129	327	157

Bundle size diffs [🚀 Bundle size reduced!]

background: -47 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -303 Bytes (-0.00%)

DDDDDanica

LGTM

aganglada self-assigned this Feb 21, 2025

aganglada requested a review from a team as a code owner February 21, 2025 13:27

metamaskbot added the team-sol PRs from the Solana snap team label Feb 21, 2025

aganglada requested a review from Gudahtt February 21, 2025 13:28

aganglada requested a review from a team as a code owner February 21, 2025 14:44

aganglada force-pushed the SOL-134-extension-replace-experimental-toggle-for-rc-with-remote-flags branch from ec34c73 to 21a7f01 Compare February 24, 2025 08:57

ccharly reviewed Feb 24, 2025

View reviewed changes

ui/selectors/multichain/networks.test.ts Outdated Show resolved Hide resolved

ui/selectors/multichain/networks.ts Outdated Show resolved Hide resolved

ccharly reviewed Feb 24, 2025

View reviewed changes

ui/selectors/multichain/networks.ts Outdated Show resolved Hide resolved

aganglada requested review from a team as code owners February 24, 2025 14:31

aganglada added 6 commits February 24, 2025 15:31

feat: replace experimental add solana account with remote flag

343b89e

chore: fix test

d7dea2c

chore: review fixes

1faa1f3

chore: fix snapshot test

3387c39

chore: fix snapshot test

44be69d

chore: handling logic on the selector

79feb37

aganglada force-pushed the SOL-134-extension-replace-experimental-toggle-for-rc-with-remote-flags branch from da2ddf0 to 79feb37 Compare February 24, 2025 14:31

ccharly reviewed Feb 24, 2025

View reviewed changes

ui/selectors/multichain/networks.test.ts Show resolved Hide resolved

ui/selectors/multichain/networks.test.ts Outdated Show resolved Hide resolved

ui/selectors/multichain/networks.test.ts Outdated Show resolved Hide resolved

ui/selectors/multichain/networks.test.ts Show resolved Hide resolved

chore: fix networks test

34e27a9

ccharly reviewed Feb 24, 2025

View reviewed changes

ui/selectors/multichain/networks.test.ts Show resolved Hide resolved

chore: fix networks test

29827e9

DDDDDanica approved these changes Feb 24, 2025

View reviewed changes

zone-live approved these changes Feb 25, 2025

View reviewed changes

aganglada added this pull request to the merge queue Feb 25, 2025

Merged via the queue into main with commit 0ad093f Feb 25, 2025
79 checks passed

aganglada deleted the SOL-134-extension-replace-experimental-toggle-for-rc-with-remote-flags branch February 25, 2025 10:48

github-actions bot locked and limited conversation to collaborators Feb 25, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace experimental add solana account with remote flag #30487

feat: replace experimental add solana account with remote flag #30487

aganglada commented Feb 21, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Feb 21, 2025

ccharly left a comment •

edited

Loading

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

DDDDDanica commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

DDDDDanica left a comment

feat: replace experimental add solana account with remote flag #30487

feat: replace experimental add solana account with remote flag #30487

Conversation

aganglada commented Feb 21, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 21, 2025

ccharly left a comment • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

DDDDDanica commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

DDDDDanica left a comment

Choose a reason for hiding this comment

aganglada commented Feb 21, 2025 •

edited by github-actions bot

Loading

ccharly left a comment •

edited

Loading