-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add bsc link to privacy snapshot #30484
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
"tx-sentinel-ethereum-mainnet.api.cx.metamask.io", | ||
"tx-sentinel-bsc-mainnet.api.cx.metamask.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be tx-sentinel-*-mainnet.api.cx.metamask.io
Hi @montelaidev , I'm curious to know if |
I saw that this new request was causing the failure of the CI for all the PRs right now. I'm not the creator of this new request, perhaps i should close this and let someone from the api team to create a pr for this new request. |
Description
This PR adds the link
tx-sentinel-bsc-mainnet.api.cx.metamask.io
to the privacy snapshot file.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist