Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bsc link to privacy snapshot #30484

Closed
wants to merge 1 commit into from

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Feb 21, 2025

Description

This PR adds the link tx-sentinel-bsc-mainnet.api.cx.metamask.io to the privacy snapshot file.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev requested a review from a team as a code owner February 21, 2025 11:55
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Comment on lines 83 to +84
"tx-sentinel-ethereum-mainnet.api.cx.metamask.io",
"tx-sentinel-bsc-mainnet.api.cx.metamask.io",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be tx-sentinel-*-mainnet.api.cx.metamask.io

@gauthierpetetin
Copy link
Contributor

Hi @montelaidev , I'm curious to know if tx-sentinel-bsc-mainnet.api.cx.metamask.io aligns with our privacy principles. I assume the answer is yes, given that the implementation is likely similar to tx-sentinel-ethereum-mainnet.api.cx.metamask.io, but I wanted to confirm this and also take the opportunity to emphasize the importance of these privacy principles throughout our organization.

@montelaidev
Copy link
Contributor Author

I saw that this new request was causing the failure of the CI for all the PRs right now. I'm not the creator of this new request, perhaps i should close this and let someone from the api team to create a pr for this new request.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@seaona
Copy link
Contributor

seaona commented Feb 21, 2025

We could merge this PR to unblock ci.
I've opened an issue here to address the root cause:

#30490

and this one for adding a mock

#30491

@seaona seaona reopened this Feb 21, 2025
@seaona
Copy link
Contributor

seaona commented Feb 21, 2025

this issue is now fixed by this PR from @Gudahtt , so we can close the PR

#30507

@seaona seaona closed this Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants