Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update users with specific error messages #30479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Setland34
Copy link

@Setland34 Setland34 commented Feb 21, 2025

Fixes #4559

Update error handling in app/scripts/controllers/account-tracker-controller.ts to propagate specific contract error messages.

  • Modify the #updateAccount function to log specific error messages when balance fetching fails.

For more details, open the Copilot Workspace session.

Fixes MetaMask#4559

Update error handling in `app/scripts/controllers/account-tracker-controller.ts` to propagate specific contract error messages.

* Modify the `#updateAccount` function to log specific error messages when balance fetching fails.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MetaMask/metamask-extension/issues/4559?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link
Contributor

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@Setland34

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal JSON-RPC error is not specific enough
2 participants