Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cherry-pick): re-enable account syncing (#30464) #30469

Merged

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Feb 20, 2025

Description

This cherry-pick PR re-enables account syncing.
This was disabled in this PR, but shouldn't have been.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Import your SRP
  2. Verify that your accounts are downloaded

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

This PR re-enables account syncing.
This was disabled in [this
PR](#29656), but
shouldn't have been.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30464?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Import your SRP
2. Verify that your accounts are downloaded

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu marked this pull request as ready for review February 20, 2025 12:53
@metamaskbot
Copy link
Collaborator

Builds ready [2a6dece]
Page Load Metrics (1672 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26919991579321154
domContentLoaded14392113164715675
load14872120167215273
domInteractive239435199
backgroundConnect85929199
firstReactRender1395382613
getState45810126
initialActions01000
loadScripts9981560118513163
setupStore66616199
uiStartup16672431192518790

@danjm danjm merged commit 55c28ee into Version-v12.13.0 Feb 20, 2025
115 of 118 checks passed
@danjm danjm deleted the Version-v12.13.0-cherrypick-re-enable-account-syncing branch February 20, 2025 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 20, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.13.0 on PR, as PR was cherry-picked in branch 12.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants