Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove circular dependencies from ui/components/* #30457

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Feb 19, 2025

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [b8a297c]
Page Load Metrics (1798 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31721351710366176
domContentLoaded15052116176817986
load15132139179818489
domInteractive157837157
backgroundConnect990342612
firstReactRender1594322311
getState562242210
initialActions01000
loadScripts10591609127515072
setupStore86916189
uiStartup17172459206620096
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 784 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f2fd0d8]
Page Load Metrics (1797 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25119431714347167
domContentLoaded1611189917658943
load16251948179710048
domInteractive26205524120
backgroundConnect10143403216
firstReactRender1598372613
getState65815136
initialActions01000
loadScripts1134143512888541
setupStore887323014
uiStartup18812677210919995
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 784 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review February 20, 2025 17:13
@davidmurdoch davidmurdoch requested review from a team, HowardBraham and dbrans as code owners February 20, 2025 17:13
HowardBraham
HowardBraham previously approved these changes Feb 20, 2025
dbrans
dbrans previously approved these changes Feb 20, 2025
Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidmurdoch davidmurdoch dismissed stale reviews from dbrans and HowardBraham via 6df4f41 February 20, 2025 17:21
@davidmurdoch davidmurdoch requested review from HowardBraham and dbrans and removed request for HowardBraham February 20, 2025 17:21
dbrans
dbrans previously approved these changes Feb 20, 2025
HowardBraham
HowardBraham previously approved these changes Feb 20, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [6df4f41]
Page Load Metrics (1615 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint137421321614212102
domContentLoaded134120501577209100
load13732057161520398
domInteractive23117462813
backgroundConnect9225394522
firstReactRender1487292211
getState4119212914
initialActions01000
loadScripts9541589115119392
setupStore77219199
uiStartup157923651864216104
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 784 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch dismissed stale reviews from HowardBraham and dbrans via 37618fa February 20, 2025 18:22
@metamaskbot
Copy link
Collaborator

Builds ready [bced044]
Page Load Metrics (1749 ± 159 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint146527861746335161
domContentLoaded145527701717319153
load146628411749332159
domInteractive2689472211
backgroundConnect1085312110
firstReactRender146927199
getState571262512
initialActions01000
loadScripts102222151254289139
setupStore86915157
uiStartup168031021984345166
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 747 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@davidmurdoch davidmurdoch requested a review from dbrans February 20, 2025 19:09
@davidmurdoch davidmurdoch added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit e96b5db Feb 20, 2025
79 checks passed
@davidmurdoch davidmurdoch deleted the circles-comp branch February 20, 2025 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants