-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nested transaction data #30447
Open
matthewwalsh0
wants to merge
11
commits into
feat/atomic-batch-transactions
Choose a base branch
from
feat/batch-confirmation
base: feat/atomic-batch-transactions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: nested transaction data #30447
matthewwalsh0
wants to merge
11
commits into
feat/atomic-batch-transactions
from
feat/batch-confirmation
+448
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [985558f]
Page Load Metrics (1686 ± 83 ms)
|
pedronfigueiredo
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO-NOT-MERGE
Pull requests that should not be merged
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display nested transaction data in batch transaction confirmations.
Specifically:
NestedTransactionData
component.useFourByte
hook withdata
andto
.useDecodedTransactionData
hook to support optionaldata
andto
properties.TransactionData
component to support optionaldata
andto
properties.RecipientRow
to support optionalrecipient
property.TransactionData
if nested transactions.Related issues
Fixes: #4272
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist