Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nested transaction data #30447

Open
wants to merge 11 commits into
base: feat/atomic-batch-transactions
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 19, 2025

Description

Display nested transaction data in batch transaction confirmations.

Specifically:

  • Add NestedTransactionData component.
  • Replace properties of useFourByte hook with data and to.
  • Extend useDecodedTransactionData hook to support optional data and to properties.
  • Extend TransactionData component to support optional data and to properties.
  • Extend RecipientRow to support optional recipient property.
  • Hide root TransactionData if nested transactions.

Open in GitHub Codespaces

Related issues

Fixes: #4272

Manual testing steps

Screenshots/Recordings

Before

After

Confirmation Collapsed Expanded

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [985558f]
Page Load Metrics (1686 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30821441628351168
domContentLoaded14422075166416680
load14512120168617283
domInteractive23161443115
backgroundConnect86424189
firstReactRender1473392412
getState36213157
initialActions01000
loadScripts10491612124314871
setupStore75816168
uiStartup168225271960227109

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review February 21, 2025 14:01
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner February 21, 2025 14:01
@matthewwalsh0 matthewwalsh0 added the DO-NOT-MERGE Pull requests that should not be merged label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants