Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Expose E2E Chrome driver extension ID #30444

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 19, 2025

Description

The extensionId property was accidentally omitted by the ChromeDriver builder. This was an old mistake, made in #7690. You can see this property is expected in test/e2e/webdriver/index.js, though in practice we don't use this extensionId for anything right now.

This was fixed so that we could use the extensionId in the future if necessary. This was extracted from #27782, which used this ID in some API spec e2e test helpers.

Open in GitHub Codespaces

Related issues

Extracted from #27782

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The `extensionId` property was accidentally omitted by the ChromeDriver
builder. This was an old mistake, made in #7690. You can see this
property is expected in `test/e2e/webdriver/index.js`, though in
practice we don't use this `extensionId` for anything right now.

This was fixed so that we could use the `extensionId` in the future if
necessary. This was extracted from #27782, which used this ID in some
API spec e2e test helpers.
@metamaskbot
Copy link
Collaborator

Builds ready [50d5b76]
Page Load Metrics (1738 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14442261173915775
domContentLoaded14362246170816077
load14452266173815876
domInteractive257934126
backgroundConnect1078322010
firstReactRender147228199
getState66017178
initialActions01000
loadScripts9831714124114670
setupStore773292411
uiStartup17772592201217082
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review February 19, 2025 22:09
@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label Feb 20, 2025
@Gudahtt Gudahtt added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 94e764b Feb 20, 2025
85 checks passed
@Gudahtt Gudahtt deleted the return-chrome-driver-extension-id branch February 20, 2025 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-extension-platform Extension Platform team team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants