chore(runway): cherry-pick fix: cp-12.13.0 fixes drag and drop in network list menu modal #30442
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the drag-and-drop functionality in the
network list menu by isolating the modal animation to only use opacity
instead of transform. The transform animation was interfering with the
react-beautiful-dnd
library's positioning calculations, causing thedraggable items to behave incorrectly.
The solution introduces a custom
network-menu-fade
animation in theindex.scss
file for the network menu modal, which only animatesopacity and removes the
transform
property. This ensures thedrag-and-drop functionality works as expected while maintaining a smooth
fade-in animation.
Key Changes:
network-menu-fade
animation inindex.scss
.transform
from the modal to fix drag-and-drop behavior.affecting other modals.
Related issues
Fixes: #30436
Manual testing steps
modal fades in correctly.
Screenshots/Recordings
Before
interference.
modal.slideup.720.mov
After
network.modal.fix720.mov
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable.
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. f28216f