fix: flaky test Speed Up and Cancel Transaction Tests Cancel transaction Successfully cancels a pending transaction

[seaona]

Description

In our ganache instance, auto-mining is set with blockTime: 2 , so a new block is mined every 2 seconds.
In the specs cancel/speed up, we are sending a transaction with low gas, so then we can speed it up/cancel. The problem is if this whole confirm and speed up/cancel, happens in the same block (within the 2 seconds).

Then the transaction stays forever in a Pending state, and the spec fails as it cannot find the correct tx status.
To fix this, we can make sure that we are working with a deterministic block behaviour. So after we confirm the tx we mine a block, and after we speed up/cancel, we mine another block.

Ci failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/125141/workflows/92ff1531-7350-490d-bfd1-811098db7535/jobs/4556227/tests

Related issues

Fixes:

Manual testing steps

1. Check ci webpack job https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/126169/workflows/f76d3a08-d90e-4cae-8033-897e85cf29d6/jobs/4563925

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[seaona]

this is not needed in this spec, as we are not interacting with any smart contract

[seaona]

this is not needed in this spec, as we are not interacting with any smart contract

[seaona]

not needed as it's handled in the below method

[seaona]

not needed as it's done in the below step

[metamaskbot]

Builds ready [bfee23b]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1650 ± 37 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1501	1783	1647	77	37
		domContentLoaded	1470	1751	1618	73	35
		load	1509	1770	1650	76	37
		domInteractive	15	70	32	11	5
		backgroundConnect	9	79	39	21	10
		firstReactRender	14	87	26	21	10
		getState	5	74	25	21	10
		initialActions	0	1	0	0	0
		loadScripts	1006	1290	1162	70	34
		setupStore	6	54	13	13	6
		uiStartup	1698	2231	1880	112	54

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)