Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the connections menu for dapp connections #30434

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Feb 19, 2025

This PR is to update the dapp connections flow. We have added a new ayer by adding connections modal

Related issues

Fixes: 4103

Manual testing steps

  1. Run extension with process.env.REMOVE_GNS
  2. Connect extension to a Dapp and check the updated popover
  3. When disconnected, click on connections icon and check the updated popover
  4. NOTE: In connected state, network name is not implemented. Will update it later

OR
Run storybook, check for ConnectedSitePopover Story

Screenshots/Recordings

Before

After

Not connected Story

Screenshot 2025-02-25 at 7 06 52 PM

Connected Story

Screenshot 2025-02-25 at 7 07 19 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha changed the title fix: This PR is to update the connections menu for dapp connections fix: Update the connections menu for dapp connections Feb 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [12f595d]
Page Load Metrics (1802 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27620661655439211
domContentLoaded14992101177416278
load15142110180216579
domInteractive1994412210
backgroundConnect1083352512
firstReactRender1570332311
getState55819209
initialActions01000
loadScripts10631589129514168
setupStore86215147
uiStartup174026172075214103
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.86 KiB (0.06%)
  • common: 86 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [565ab33]
Page Load Metrics (1803 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24820421646460221
domContentLoaded152724011773211101
load15432406180320799
domInteractive20175473919
backgroundConnect105930199
firstReactRender1493372713
getState564232311
initialActions00000
loadScripts10771782129517483
setupStore693192311
uiStartup173326352076248119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.8 KiB (0.06%)
  • common: 217 Bytes (0.00%)

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [97ed9fc]
Page Load Metrics (1855 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24821591686495238
domContentLoaded15862096181914972
load15932167185516378
domInteractive23141432613
backgroundConnect1089382412
firstReactRender147028199
getState56319189
initialActions00000
loadScripts11631650137912962
setupStore86620209
uiStartup18312393211117283
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 5.42 KiB (0.07%)
  • common: 217 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants