Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submit multichain tx #30416

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: submit multichain tx #30416

wants to merge 14 commits into from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 19, 2025

Description

Changes

  • update useLatestBalance to return non-evm balances
  • disable CTA when balance is insuffifient
  • use solana wallet snap to submit transaction

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1869

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Feb 19, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 704 kB metamaskbot

View full report↗︎

Copy link

socket-security bot commented Feb 19, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫
Network access npm/@metamask/[email protected] 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@micaelae micaelae force-pushed the mms1867-chain-agnostic-bridge-components branch from d6ad1ab to 777a478 Compare February 19, 2025 01:40
@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from 4baf374 to b99bf92 Compare February 19, 2025 01:43
@micaelae micaelae changed the base branch from mms1867-chain-agnostic-bridge-components to main February 19, 2025 01:43
@micaelae micaelae marked this pull request as ready for review February 19, 2025 01:49
@micaelae micaelae requested a review from a team as a code owner February 19, 2025 01:49
@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from b99bf92 to 6c9c8f4 Compare February 19, 2025 15:32
ghgoodreau
ghgoodreau previously approved these changes Feb 19, 2025
params: {
request: {
params: { base64EncodedTransactionMessage: txParams },
method: 'sendAndConfirmTransaction',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will soon remove this method and this logic will be on the standard signAndSendTransaction. Let us create a new version of the snap in order to update this

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from 79efaad to a87efb0 Compare February 25, 2025 03:37
@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from 2680ffe to a4ca36f Compare February 25, 2025 20:46
@micaelae micaelae removed the request for review from a team February 25, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants