-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: text visibility issues in error page in dark mode #30408
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -1,6 +1,8 @@ | |||
.mm-textarea { | |||
$resize: none, both, horizontal, vertical, initial, inherit; | |||
|
|||
max-width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing !
|
||
html, | ||
body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to include body
here so it inherits the color styles for text at the moment we are setting it to text/default which defaults to grey
after.body720.mov
@@ -110,16 +110,27 @@ const ErrorPage: React.FC<ErrorPageProps> = ({ error }) => { | |||
size={IconSize.Xl} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page will be rendered outside of the theme provider so we need to ensure it works by changing all text components to inherit the text color from html/body
Builds ready [ed2034e]
Page Load Metrics (1816 ± 130 ms)
Bundle size diffs
|
LGTM ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR addresses an issue where the error page text was not visible in dark mode due to missing theme handling and color inheritance. The changes ensure proper text visibility regardless of the user's system theme by:
TextColor.inherit
to all text components in the error page to ensure proper color inheritanceRelated issues
Fixes: #30407
Manual testing steps
if (true) {
inui/pages/index.js
Textarea
component to ensure it doesn't overflow its containerScreenshots/Recordings
Before
error.page.bug720.mov
After
after720.mov
storybook.after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist