Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics to carousel banner #30405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add metrics to carousel banner #30405

wants to merge 2 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Feb 18, 2025

Description

Adds firing of metrics when the user clicks on the carousel dots or on the left or right side of the banner (incl associated banner name).

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4228

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner February 18, 2025 15:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d6557d1]
Page Load Metrics (1809 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30521131711381183
domContentLoaded145622391784217104
load146422811809228110
domInteractive24109402010
backgroundConnect87426199
firstReactRender1481322512
getState45919189
initialActions01000
loadScripts10291691130218287
setupStore764222010
uiStartup170726142070255123
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 575 Bytes (0.01%)
  • common: 37 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants