Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snaps): Add crossAlignment to Box #30400

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Feb 18, 2025

Description

This PR adds the crossAlignment prop to the Snap UI Box component. It generates a align-items property.

Open in GitHub Codespaces

Related issues

Fixes: #30368

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx marked this pull request as ready for review February 18, 2025 14:59
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner February 18, 2025 14:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Feb 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [448508e]
Page Load Metrics (1578 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13651834158011756
domContentLoaded13571824155911455
load13661835157811856
domInteractive23100412412
backgroundConnect106522178
firstReactRender1483422713
getState44710126
initialActions01000
loadScripts9411360113110048
setupStore75713147
uiStartup15282324182418790

@GuillaumeRx GuillaumeRx force-pushed the gr/add-cross-alignment-box branch from 448508e to 6fe7fb9 Compare February 18, 2025 16:02
@metamaskbot
Copy link
Collaborator

Builds ready [de6ee5b]
Page Load Metrics (1796 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22421721631490235
domContentLoaded14692149177120699
load147921681796210101
domInteractive23142493316
backgroundConnect96829189
firstReactRender1477362211
getState55223188
initialActions01000
loadScripts9961616128618287
setupStore75517147
uiStartup165728892097299143

@FrederikBolding FrederikBolding merged commit f57a80a into fb/snaps-bump-v90 Feb 19, 2025
63 of 66 checks passed
@FrederikBolding FrederikBolding deleted the gr/add-cross-alignment-box branch February 19, 2025 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants