Temp investigate performance on lists #30393
Draft
+916
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were creating a new obj on every selector call (almost every state change)
spotted from new eslint ruleset
prevent JSX elements from being re-created, and optimize a hook used for formatting tokens
this is a small win, I think we would get some larger wins if we were to virtualize or optimize logic (since we can see that rendering isn't what takes time, but the logic)
no major wins here. Need to investigate more on why some list items are spending time doing calculations.
lets attempt using a virtual list for tokens too.
removes the large re-renders we see from this list. But we need to do some thorough investigation to see if this is working as expected
OK seeing some perf improvements... but there is still an initial "lag" when using portfolio view...
we should probably make a cleaner hook for demo purposes.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short investigation on account menu and notes for performance.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist