feat(multi-srp): add number_of_hd_entropies metrics user trait #30392

PatrykLucka · 2025-02-18T12:36:49Z

Description

Adds number_of_hd_entropies to metametrics user traits.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-18T12:37:04Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-18T13:10:40Z

Builds ready [1269ed7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1738 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1554	2095	1734	140	67
		domContentLoaded	1534	2085	1700	139	67
		load	1555	2151	1738	146	70
		domInteractive	21	102	45	26	12
		backgroundConnect	10	77	37	22	11
		firstReactRender	17	76	38	24	12
		getState	6	62	18	18	8
		initialActions	0	1	0	0	0
		loadScripts	1097	1558	1238	117	56
		setupStore	8	82	18	20	10
		uiStartup	1801	2408	2021	168	81

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 360 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 37 Bytes (0.00%)

metamaskbot · 2025-02-19T15:04:50Z

Builds ready [fe06ffe]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1750 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	401	2344	1678	374	180
		domContentLoaded	1461	2328	1724	244	117
		load	1470	2401	1750	246	118
		domInteractive	23	121	44	27	13
		backgroundConnect	8	76	31	22	11
		firstReactRender	14	100	29	26	13
		getState	5	79	29	24	11
		initialActions	0	1	0	0	0
		loadScripts	1004	1793	1232	203	97
		setupStore	8	58	15	15	7
		uiStartup	1719	2664	2013	298	143

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 370 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 47 Bytes (0.00%)

metamaskbot · 2025-02-19T15:04:53Z

Builds ready [fe06ffe]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1750 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	401	2344	1678	374	180
		domContentLoaded	1461	2328	1724	244	117
		load	1470	2401	1750	246	118
		domInteractive	23	121	44	27	13
		backgroundConnect	8	76	31	22	11
		firstReactRender	14	100	29	26	13
		getState	5	79	29	24	11
		initialActions	0	1	0	0	0
		loadScripts	1004	1793	1232	203	97
		setupStore	8	58	15	15	7
		uiStartup	1719	2664	2013	298	143

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 370 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 47 Bytes (0.00%)

metamaskbot · 2025-02-19T15:54:41Z

Builds ready [86e4ab4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1600 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1466	1762	1591	87	42
		domContentLoaded	1456	1741	1566	87	42
		load	1468	1807	1600	91	44
		domInteractive	22	121	46	31	15
		backgroundConnect	10	160	37	37	18
		firstReactRender	14	95	41	27	13
		getState	5	52	13	14	7
		initialActions	0	1	0	0	0
		loadScripts	1022	1293	1126	92	44
		setupStore	7	70	17	19	9
		uiStartup	1683	2265	1830	131	63

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 370 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 47 Bytes (0.00%)

shared/constants/metametrics.ts

danroc · 2025-02-25T15:36:08Z

app/scripts/controllers/metametrics-controller.ts

@@ -175,6 +176,7 @@ export type MetaMaskState = {
    };
  };
  ///: END:ONLY_INCLUDE_IF
+  keyrings: { type: string; accounts: string[] }[];


Is the accounts property used?

Not in this PR, but accounts are there, we're just adding something that was passed in the state anyway, but was not added to the type.

danroc · 2025-02-25T15:36:49Z

app/scripts/controllers/metametrics-controller.ts

@@ -175,6 +176,7 @@ export type MetaMaskState = {
    };
  };
  ///: END:ONLY_INCLUDE_IF
+  keyrings: { type: string; accounts: string[] }[];


Can keyring.type by typed (KeyringType) or is there a reason to use a string here?

It's just for consistency. It is defined as string in the KeyringController and ui store (TemporaryBackgroundState).

app/scripts/controllers/metametrics-controller.test.ts

Co-authored-by: Daniel Rocha <[email protected]>

PatrykLucka self-assigned this Feb 18, 2025

metamaskbot added the team-mmi PRs from the MMI team label Feb 18, 2025

PatrykLucka closed this Feb 19, 2025

PatrykLucka force-pushed the MMMULTISRP-41-add-number-of-hd-srps-to-segment-events branch from 82fdb5a to fad21cd Compare February 19, 2025 12:51

github-actions bot locked and limited conversation to collaborators Feb 19, 2025

PatrykLucka reopened this Feb 19, 2025

feat(multi-srp): add number_of_hd_entropies user trait

86e4ab4

PatrykLucka force-pushed the MMMULTISRP-41-add-number-of-hd-srps-to-segment-events branch from fe06ffe to 86e4ab4 Compare February 19, 2025 15:17

PatrykLucka marked this pull request as ready for review February 20, 2025 09:34

PatrykLucka changed the title ~~feat(multi-srp): add number_of_hd_srps metrics user trait~~ feat(multi-srp): add number_of_hd_entropies metrics user trait Feb 20, 2025

danroc reviewed Feb 25, 2025

View reviewed changes

shared/constants/metametrics.ts Outdated Show resolved Hide resolved

danroc reviewed Feb 25, 2025

View reviewed changes

app/scripts/controllers/metametrics-controller.test.ts Outdated Show resolved Hide resolved

PatrykLucka and others added 2 commits February 25, 2025 17:42

Update shared/constants/metametrics.ts

626a462

Co-authored-by: Daniel Rocha <[email protected]>

test: add getNumberOfHDEntropies unit tests

648d23a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(multi-srp): add number_of_hd_entropies metrics user trait #30392

feat(multi-srp): add number_of_hd_entropies metrics user trait #30392

PatrykLucka commented Feb 18, 2025 •

edited

Loading

github-actions bot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

danroc Feb 25, 2025

PatrykLucka Feb 25, 2025

danroc Feb 25, 2025

PatrykLucka Feb 25, 2025

feat(multi-srp): add number_of_hd_entropies metrics user trait #30392

Are you sure you want to change the base?

feat(multi-srp): add number_of_hd_entropies metrics user trait #30392

Conversation

PatrykLucka commented Feb 18, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

danroc Feb 25, 2025

Choose a reason for hiding this comment

PatrykLucka Feb 25, 2025

Choose a reason for hiding this comment

danroc Feb 25, 2025

Choose a reason for hiding this comment

PatrykLucka Feb 25, 2025

Choose a reason for hiding this comment

PatrykLucka commented Feb 18, 2025 •

edited

Loading