chore: delete mmi-controller and code behind build-mmi

[mikesposito]

Description

This PR deletes:

• app/scripts/controllers/mmi-controller.ts
• app/scripts/controllers/mmi-controller.test.ts
• app/scripts/lib/rpc-method-middleware/handlers/institutional/
• all the code behind the build-mmi flag, from all files

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@metamask-institutional/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[mikesposito]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [4d8a199]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1984 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	436	2403	1903	395	190
		domContentLoaded	1442	2366	1952	206	99
		load	1452	2421	1984	210	101
		domInteractive	25	140	48	29	14
		backgroundConnect	10	80	34	22	10
		firstReactRender	15	83	48	24	12
		getState	5	64	21	19	9
		initialActions	0	1	0	0	0
		loadScripts	1008	1830	1432	166	80
		setupStore	8	57	19	13	6
		uiStartup	1699	2746	2289	250	120

Bundle size diffs [🚀 Bundle size reduced!]

• background: -79 Bytes (-0.00%)
• ui: 0 Bytes (0.00%)
• common: -174 Bytes (-0.00%)