-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cp-12.13.0 Disable origin throttling middleware if cause is "rejectAllApprovals" #30388
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
@metamaskbot update-policies |
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [db7c64f]
Page Load Metrics (1670 ± 52 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR aims to fix
release-blocker
inv12.13.0
which disables origin throttling middleware ifcause
isrejectAllApprovals
.Patch note:
Currently bumping
transaction-controller
is blocked because it's breaking e2e tests https://consensys.slack.com/archives/CTQAGKY5V/p1739968847746929?thread_ts=1739869734.799669&cid=CTQAGKY5VTo avoid applying version newer version of
transaction-controller
needed change patched in this PR. Required change is already in the core repository MetaMask/core#5355. And will most likely be released in version46.0.1
. Then we will most likely bumptransaction-controller
inmain
.Related issues
Fixes: #30333
Manual testing steps
See the task details
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist