Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-12.13.0 Disable origin throttling middleware if cause is "rejectAllApprovals" #30388

Merged
merged 14 commits into from
Feb 19, 2025

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Feb 18, 2025

Description

This PR aims to fix release-blocker in v12.13.0 which disables origin throttling middleware if cause is rejectAllApprovals.

Patch note:
Currently bumping transaction-controller is blocked because it's breaking e2e tests https://consensys.slack.com/archives/CTQAGKY5V/p1739968847746929?thread_ts=1739869734.799669&cid=CTQAGKY5V
To avoid applying version newer version of transaction-controller needed change patched in this PR. Required change is already in the core repository MetaMask/core#5355. And will most likely be released in version 46.0.1. Then we will most likely bump transaction-controller in main.

Open in GitHub Codespaces

Related issues

Fixes: #30333

Manual testing steps

See the task details

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 18, 2025
Copy link

socket-security bot commented Feb 18, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@OGPoyraz OGPoyraz requested a review from a team as a code owner February 19, 2025 10:09
@OGPoyraz
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested review from a team as code owners February 19, 2025 10:24
@OGPoyraz OGPoyraz removed request for a team February 19, 2025 12:16
@metamaskbot
Copy link
Collaborator

Builds ready [db7c64f]
Page Load Metrics (1670 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14701918166811254
domContentLoaded1464184316459847
load14711915167010952
domInteractive26101442211
backgroundConnect973272010
firstReactRender1474322311
getState55111136
initialActions00000
loadScripts1030134211878842
setupStore76517199
uiStartup17282354192615574
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 161 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 23 Bytes (0.00%)

@itsyoboieltr itsyoboieltr changed the title fix: Disable origin throttling middleware if cause is "rejectAllApprovals" fix: cp-12.13.0 Disable origin throttling middleware if cause is "rejectAllApprovals" Feb 19, 2025
Copy link
Contributor

@itsyoboieltr itsyoboieltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 42bd11d Feb 19, 2025
85 checks passed
@itsyoboieltr itsyoboieltr deleted the ogp/30333 branch February 19, 2025 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Confirmations - Spam filter is activated despite Rejecting it
4 participants