Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Feb 18, 2025

This PR is relative to solve the plan 835

This PR including following change:

  1. in actions.js file, change connectHardware method signature to has extra loadHid boolean parameter to see whether we need to load HID request prompt up.
  2. change connect-hardware/index.js to and pass loadHid = true parameter value to above actions.
  3. change connect-hardware/account-list.js and all pagination feature relative functions to pass loadHid = false to disable HID request popup apear.

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/835

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 changed the title feat: First draft fix for HID request keep promping up. feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. Feb 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2dcab12]
Page Load Metrics (1832 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14782222183719393
domContentLoaded14722198179718890
load14772216183218991
domInteractive28143553316
backgroundConnect9200394320
firstReactRender1578372512
getState468202010
initialActions01000
loadScripts10661628131915976
setupStore858242010
uiStartup174426602089222106
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 17 Bytes (0.00%)
  • common: 5 Bytes (0.00%)

@dawnseeker8 dawnseeker8 marked this pull request as ready for review February 19, 2025 01:06
@metamaskbot
Copy link
Collaborator

Builds ready [cf89481]
Page Load Metrics (1654 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45718581591277133
domContentLoaded1468184716309043
load1520185716548842
domInteractive257838189
backgroundConnect971282110
firstReactRender1475402512
getState55611147
initialActions00000
loadScripts1005133711788641
setupStore66014157
uiStartup1718208718869948
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 17 Bytes (0.00%)
  • common: 5 Bytes (0.00%)

@dawnseeker8 dawnseeker8 added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware-ledger needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-hardware-wallets
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants