feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384
+11
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is relative to solve the plan 835
This PR including following change:
connectHardware
method signature to has extraloadHid
boolean parameter to see whether we need to load HID request prompt up.connect-hardware/index.js
to and passloadHid = true
parameter value to above actions.connect-hardware/account-list.js
and all pagination feature relative functions to passloadHid = false
to disable HID request popup apear.Description
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/835
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist