Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-srp): add hd_entropy_index to segment events #30382

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Feb 18, 2025

Description

Adds hd_entropy_index to the events listed it in this document: Event Listing

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@PatrykLucka PatrykLucka self-assigned this Feb 18, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Feb 18, 2025
@PatrykLucka PatrykLucka changed the title Mmmultisrp 44 add hd srp index to segment events feat(multi-srp): add hd_srp_index to segment events Feb 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3d02988]
Page Load Metrics (1843 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23020831754375180
domContentLoaded14652064180814369
load15142088184313967
domInteractive24573584
backgroundConnect1187372311
firstReactRender1595382612
getState593242512
initialActions00000
loadScripts10221539128712359
setupStore85913115
uiStartup170726622136231111
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 546 Bytes (0.01%)
  • ui: 4.66 KiB (0.06%)
  • common: 560 Bytes (0.01%)

@PatrykLucka PatrykLucka force-pushed the MMMULTISRP-44-add-hd-srp-index-to-segment-events branch 2 times, most recently from 3f18fc2 to b59a6ec Compare February 20, 2025 09:48
@metamaskbot
Copy link
Collaborator

Builds ready [b59a6ec]
Page Load Metrics (1749 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21520421613464223
domContentLoaded15012027172615474
load15522047174915373
domInteractive23663294
backgroundConnect96826188
firstReactRender156730199
getState55918178
initialActions0523115
loadScripts10141465124414268
setupStore86617178
uiStartup17562355200717986
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 606 Bytes (0.01%)
  • ui: 4.96 KiB (0.06%)
  • common: 592 Bytes (0.01%)

@PatrykLucka PatrykLucka marked this pull request as ready for review February 20, 2025 10:35
@PatrykLucka PatrykLucka requested review from a team as code owners February 20, 2025 10:35
@PatrykLucka PatrykLucka changed the title feat(multi-srp): add hd_srp_index to segment events feat(multi-srp): add hd_entropy_index to segment events Feb 20, 2025
@PatrykLucka PatrykLucka force-pushed the MMMULTISRP-44-add-hd-srp-index-to-segment-events branch from d8e4908 to 5430bf3 Compare February 25, 2025 11:32
@metamaskbot
Copy link
Collaborator

Builds ready [5430bf3]
Page Load Metrics (1613 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14661832162010450
domContentLoaded1462179815949646
load1466181616139445
domInteractive248535188
backgroundConnect85524167
firstReactRender1470322210
getState44612115
initialActions00000
loadScripts1047133511768039
setupStore75815168
uiStartup16332041181810048
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 602 Bytes (0.01%)
  • ui: 4.96 KiB (0.07%)
  • common: 592 Bytes (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-mmi PRs from the MMI team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

5 participants