Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix edge case for uploading git diff artifacts needed for POM … #30365

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Feb 17, 2025

…github action and skip validation for RC (#30295)

Description

Before, we skipped performing the git-diff operation in cases where the PR was not targetting the default branch or when there was the skip-e2e-quality-gate label.
However, now we still need to perform the git-diff, as the artifacts are consumed not only by the e2e quality gate, but also by the Page Object Model validation github action, and it could be consumed by more jobs in the future.
So, no matter if we want to skip the e2e quality gate, we still perform the git diff.

This PR adds the base PR and the labels into the PR info file artifact, so we can then read it to check if we want to skip the e2e quality gate. And it performs the git diff (uploading the diff artifacts and PR info) always, to be accessible from other jobs.

It also skips the POM validation on PRs which don't target main.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  • check ci artifacts for PR info: now pr info has the PR labels as well as the PR base

  • Git diff is performed no matter if I have applied the skip-e2e-quality-gate label

Screenshots/Recordings

See PR label and base added in the top of PR info artifact

Screenshot from 2025-02-14 11-48-19

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…github action and skip validation for RC (#30295)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Before, we skipped performing the `git-diff` operation in cases where
the PR was not targetting the default branch or when there was the
`skip-e2e-quality-gate` label.
However, now we still need to perform the git-diff, as the artifacts are
consumed not only by the e2e quality gate, but also by the Page Object
Model validation github action, and it could be consumed by more jobs in
the future.
So, no matter if we want to skip the e2e quality gate, we still perform
the git diff.

This PR adds the base PR and the labels into the PR info file artifact,
so we can then read it to check if we want to skip the e2e quality gate.
And it performs the git diff (uploading the diff artifacts and PR info)
always, to be accessible from other jobs.

It also skips the POM validation on PRs which don't target `main`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30295?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

- [check ci
artifacts](https://circleci-tasks-prod.s3.us-east-1.amazonaws.com/storage/artifacts/fb281712-ea41-446f-b28f-c0bea18842cc/04b7f9bd-6353-43e1-b2a8-5104e5286774/0/changed-files/pr-body.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Checksum-Mode=ENABLED&X-Amz-Credential=ASIAQVFQINEOMLWNSGNO%2F20250214%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20250214T115938Z&X-Amz-Expires=60&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEAQaCXVzLWVhc3QtMSJGMEQCIEmPY58AcRhJG3dQ3CcB6ERDkKb4h2gNAg7fBwZFpSOFAiB5N6qFA6r3IrEy71Ui2oPWLoXgmE4S34%2BjEQNEIHutFSqrAggtEAMaDDA0NTQ2NjgwNjU1NiIMUb0tACexmFZ3iwsaKogCr3iQRTTjeXNKC6ulWvBSVzpS9aN5TbYa9z6bU2H4Ys7iWZjGZI20MMMG1CiKu5J81j4m%2B5rKWEBsLRQZm1tXzntGjFHNLtBL2ZVlnNOw4m%2Bm2vVY1wy4a5r%2BSzFDYLnYgoBQsLxLH7a0A2bJbY4ju0f7L9lrA4M9nTPuNZhxPm5fznfaVnn%2FZbls9tDc%2F9EEyeuqyOwSUZM2uMSYMBkyCe3uy4A8k1aUB0HF7R6GDAb4v0vSpEZWCQSndPHMOwBTF9TrARAQX1gnm56B4Z5sznG3OjbrBHzWxhKcSxgmGB3dNPkiuZTmq7fZfr7cIGVBW1qUmSgVYI7WFZAe5P8jJUFtcbKQu3T8MLzfvL0GOp4B8CjFmdpcotJQy3iXkxyFvI1pYeXegpbcBReO2IiCuE01Y%2BorBw0%2BujIBkXWQUUN1JGJpetzgkJQEvILxa077MBz%2BVLJJz9krXTCDJlznFTs2cy8oY63FNi6Nd%2B%2Ban5LG6i3L4rzHRpNJMvqMZ92cusI56eKYg314ESdFIXtQh6e29fiUS9NMES48WljZsdETT%2BTw5YB%2FJiOzxFkZJGE%3D&X-Amz-SignedHeaders=host&x-id=GetObject&X-Amz-Signature=429e0beaffdf34cf408ac746ac6353f4aef3d5505fa6c888842c5ab7fa32135a)
for PR info: now pr info has the PR labels as well as the PR base

- Git diff is performed no matter if I have applied the
`skip-e2e-quality-gate` label





## **Screenshots/Recordings**
See PR label and base added in the top of PR info artifact


![Screenshot from 2025-02-14
11-48-19](https://github.com/user-attachments/assets/f55e1e41-ae6d-4b3a-b2d7-0cbec6b8e68f)


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 17, 2025
@seaona seaona marked this pull request as ready for review February 17, 2025 12:25
@seaona seaona requested a review from a team as a code owner February 17, 2025 12:25
@metamaskbot
Copy link
Collaborator

Builds ready [bf7d461]
Page Load Metrics (1605 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34618921538295142
domContentLoaded14411870158710852
load14541887160511153
domInteractive227036167
backgroundConnect7481894
firstReactRender1471332311
getState542984
initialActions01000
loadScripts9891413115410349
setupStore668222110
uiStartup16252176183614670

@itsyoboieltr itsyoboieltr merged commit 35c380a into Version-v12.13.0 Feb 17, 2025
70 checks passed
@itsyoboieltr itsyoboieltr deleted the cherrypick-pom-action branch February 17, 2025 13:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants