Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (cherry-pick): Add BNB Smart Chain to Smart Transactions description in settings #30362

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Feb 17, 2025

Cherry picks d6e21aa from main.

#29833

  • update text in _locales json
  • update Snapshot in ui/pages/settings/advanced-tab

Description

update content in Advanced Settings for BSC in the STX section to read: "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain."

Related issues

N/A

Manual testing steps

  1. Load Extension from feature branch
  2. Go to Settings > Advanced > Smart Transactions section
  3. Ensure that text reads:
  • "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain."
    instead of:
  • "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet"

Screenshots/Recordings

Before & After

stx_before

stx_after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 17, 2025
@itsyoboieltr itsyoboieltr changed the title chore (cherry-pick): Add BNB Smart Chain to Smart Transactions description chore (cherry-pick): Add BNB Smart Chain to Smart Transactions description in settings Feb 17, 2025
@itsyoboieltr itsyoboieltr requested review from danjm and dbrans and removed request for danjm February 17, 2025 10:39
Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#29833)

- update text in _locales json
- update Snapshot in `ui/pages/settings/advanced-tab`

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

update content in Advanced Settings for BSC in the STX section to read:
"Turn on Smart Transactions for more reliable and secure transactions on
Ethereum Mainnet and BNB Smart Chain."

## **Related issues**

N/A

## **Manual testing steps**

1. Load Extension from feature branch
2. Go to Settings > Advanced > Smart Transactions section
3. Ensure that text reads:
- "Turn on Smart Transactions for more reliable and secure transactions
on Ethereum Mainnet and BNB Smart Chain."
  instead of:
- "Turn on Smart Transactions for more reliable and secure transactions
on Ethereum Mainnet"

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before & After**

<img width="200" alt="stx_before"
src="https://github.com/user-attachments/assets/32e87b4e-0c14-478e-b2c8-f1b1e920c3dc"
/>

<img width="200" alt="stx_after"
src="https://github.com/user-attachments/assets/458cc292-13b9-477c-875a-828d969e405f"
/>

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@itsyoboieltr itsyoboieltr merged commit c5475bd into Version-v12.13.0 Feb 18, 2025
60 of 61 checks passed
@itsyoboieltr itsyoboieltr deleted the cherry-pick-d6e21aa branch February 18, 2025 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [92781b8]
Page Load Metrics (1633 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8261772157618991
domContentLoaded14162018161312058
load14282025163312058
domInteractive20180373517
backgroundConnect107226189
firstReactRender1572352311
getState56015168
initialActions01000
loadScripts10031528117110550
setupStore75418178
uiStartup16092311189716881

@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 18, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.13.0 on PR, as PR was cherry-picked in branch 12.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants