-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (cherry-pick): Add BNB Smart Chain to Smart Transactions description in settings #30362
Merged
+7
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
0732076
to
6997f1f
Compare
dbrans
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#29833) - update text in _locales json - update Snapshot in `ui/pages/settings/advanced-tab` <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** update content in Advanced Settings for BSC in the STX section to read: "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain." ## **Related issues** N/A ## **Manual testing steps** 1. Load Extension from feature branch 2. Go to Settings > Advanced > Smart Transactions section 3. Ensure that text reads: - "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain." instead of: - "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet" ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before & After** <img width="200" alt="stx_before" src="https://github.com/user-attachments/assets/32e87b4e-0c14-478e-b2c8-f1b1e920c3dc" /> <img width="200" alt="stx_after" src="https://github.com/user-attachments/assets/458cc292-13b9-477c-875a-828d969e405f" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
6997f1f
to
92781b8
Compare
Builds ready [92781b8]
Page Load Metrics (1633 ± 58 ms)
|
No release label on PR. Adding release label release-12.13.0 on PR, as PR was cherry-picked in branch 12.13.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.13.0
Issue or pull request that will be included in release 12.13.0
team-extension-platform
Extension Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks d6e21aa from main.
#29833
ui/pages/settings/advanced-tab
Description
update content in Advanced Settings for BSC in the STX section to read: "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain."
Related issues
N/A
Manual testing steps
instead of:
Screenshots/Recordings
Before & After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist