Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unichain logo #30361

Merged
merged 3 commits into from
Feb 17, 2025
Merged

feat: add unichain logo #30361

merged 3 commits into from
Feb 17, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Feb 17, 2025

Description

  • Add Unichain ID: 130
  • Add Network logo for Unichain and Unichain Sepolia
  • Use ETH Token Logo for Unichain and Unichain Sepolia

Open in GitHub Codespaces

Related issues

Fixes:N/A

Manual testing steps

  1. Go to app.uniswap.org
  2. Connect w/ Metamask
  3. Open In-App Wallet Settings in the right hand menu
  4. Enable Unichain Beta
  5. Attempt to Swap on Unichain Mainnet
  6. Add Unichain to Metamask Networks

Screenshots/Recordings

Before

Screenshot 2025-02-10 at 14 00 31

After

Screenshot 2025-02-10 at 14 03 57

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb marked this pull request as ready for review February 17, 2025 09:36
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [7e20dd5]
Page Load Metrics (2068 ± 155 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27823241398742356
domContentLoaded160427232033318153
load162628082068323155
domInteractive27172624220
backgroundConnect10104422613
firstReactRender1576392311
getState64617126
initialActions01000
loadScripts114421201522269129
setupStore788202110
uiStartup185733052390406195
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 163 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [7a58e5e]
Page Load Metrics (1612 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25818861477426205
domContentLoaded13731865159613364
load13811892161213565
domInteractive22109352311
backgroundConnect75618126
firstReactRender1491362412
getState46912178
initialActions01000
loadScripts9511400113911153
setupStore775172010
uiStartup15942345184417986
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 163 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 422201c Feb 17, 2025
72 of 73 checks passed
@salimtb salimtb deleted the feat/add-unichain-logo branch February 17, 2025 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants