Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: BE design system updates #30343

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Feb 14, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Extension label Feb 14, 2025
Comment on lines -45 to -51
/* Prevent font-size resizing to avoid conflcits for long asset and token names */
&__account-name button,
&__asset,
&__tooltip {
font-size: 14px !important;
}

Copy link
Contributor Author

@georgewrmarshall georgewrmarshall Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates AccountListItem to adhere to large typography

Copy link

socket-security bot commented Feb 14, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 0 B

View full report↗︎

Comment on lines -2 to -5
/* Set explicitly to match the font-size of AccountListItem */
&__label {
font-size: 14px !important;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensuring the address in account list item adheres to the Text variant that uses bodyMdMedium

@@ -301,7 +301,7 @@
"@metamask/browser-passworder": "^4.3.0",
"@metamask/contract-metadata": "^2.5.0",
"@metamask/controller-utils": "^11.4.0",
"@metamask/design-tokens": "^5.0.0",
"@metamask/design-tokens": "npm:@metamask-previews/design-tokens@5.0.0-preview.3ab3ce4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated once the design tokens package has been published with brand evolution colors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants