Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump notification services controller #30339

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 14, 2025

Description

Bump @metamask/notification-services-controller from ^0.20.1 to ^0.21.0

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Check notifications flow (enable notifications, disable notifications)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 14, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.37 MB metamaskbot

View full report↗︎

@Prithpal-Sooriya Prithpal-Sooriya changed the title chore: bump notification services controller feat: bump notification services controller Feb 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [173d52d]
Page Load Metrics (1555 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14191843156510450
domContentLoaded13471784152710350
load13561843155511354
domInteractive22100402412
backgroundConnect892332512
firstReactRender1368312211
getState485192210
initialActions01000
loadScripts950133211099244
setupStore65115147
uiStartup15662179177315675
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 204 Bytes (0.00%)

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review February 17, 2025 09:21
@metamaskbot
Copy link
Collaborator

Builds ready [23452c0]
Page Load Metrics (1555 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27018441491310149
domContentLoaded13341789153113062
load13431842155514067
domInteractive1482392010
backgroundConnect96425199
firstReactRender1364292110
getState4569115
initialActions00000
loadScripts9401331110011053
setupStore75617189
uiStartup15222032175814469
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 204 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [70d76fb]
Page Load Metrics (1618 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27818411429484233
domContentLoaded13981823159512058
load14061843161812761
domInteractive1899402612
backgroundConnect871272210
firstReactRender1470282210
getState45415178
initialActions01000
loadScripts9491348115011555
setupStore787172110
uiStartup15852142185315072
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 204 Bytes (0.00%)

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 8ae2876 Feb 18, 2025
73 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the bump-notification-services-controller branch February 18, 2025 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants