Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polkadot Asset Hub chain #30337

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add Polkadot Asset Hub chain #30337

wants to merge 2 commits into from

Conversation

pgherveou
Copy link

@pgherveou pgherveou commented Feb 14, 2025

Description

Add Polkadot Asset Hub (mainnet) and Asset Hub Westend (testnet) to the network CHAIN_IDS constant.
And set the CHAIN_ID_TO_GAS_LIMIT_BUFFER_MAP gas limit buffer multipliers for these chains to 1.

These chains do not need the default 1.5x multiplier, that also happen to break the gas estimation that encode additional gas information in the lowest digits (Polkadot uses 2 dimensionals weights for gas computation time and proof of validity size)

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@andreolf
Copy link
Member

looking into this

@alfeng6
Copy link

alfeng6 commented Feb 14, 2025

Can you please separate the PR to be 1. adding chain info 2. doing better gas estimation?

@pgherveou
Copy link
Author

Can you please separate the PR to be 1. adding chain info 2. doing better gas estimation?

Sorry I am not sure to read you well, what do you want me to separate exactly?

@pgherveou
Copy link
Author

Hey @alfeng6 following up, do you want me to create one PR with just the CHAIN_IDs.
And then another one where we add an entry to the CHAIN_ID_TO_GAS_LIMIT_BUFFER_MAP mapping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants