Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Perf: Prevent MultichainMetaFoxLogo from multiple renders #30286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Feb 13, 2025

Description

The MultichainMetaFoxLogo component rerenders because we aren't using useCallback for the onClick. This continues to happen even after logged in.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Start the extension with ENABLE_WHY_DID_YOU_RENDER=1 yarn start
  2. Don't see rerenders on the MultichainMetaFoxLogo

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner February 13, 2025 03:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b805fca]
Page Load Metrics (1663 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14321962166315273
domContentLoaded14151899163914670
load14371959166314972
domInteractive22164453416
backgroundConnect1070302010
firstReactRender1579422512
getState45815168
initialActions01000
loadScripts9681455118012962
setupStore65613136
uiStartup16042296188818589
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 581 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants