refactor: remove circular dependencies in `ui/pages/snap-account-redirect/*` #30279

davidmurdoch · 2025-02-12T22:02:50Z

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

…rect/*`

github-actions · 2025-02-12T22:03:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-12T22:37:21Z

Builds ready [96620db]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1613 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1409	1805	1613	113	54
		domContentLoaded	1401	1787	1584	112	54
		load	1425	1805	1613	112	54
		domInteractive	24	91	38	21	10
		backgroundConnect	8	64	29	19	9
		firstReactRender	14	69	34	23	11
		getState	5	60	14	16	8
		initialActions	0	0	0	0	0
		loadScripts	1005	1288	1153	90	43
		setupStore	6	53	10	10	5
		uiStartup	1635	2059	1825	123	59

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -567 Bytes (-0.01%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-13T21:12:51Z

Builds ready [7197c34]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1616 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1429	2120	1610	146	70
		domContentLoaded	1417	2098	1586	141	68
		load	1431	2124	1616	143	69
		domInteractive	23	87	36	19	9
		backgroundConnect	10	99	31	21	10
		firstReactRender	13	72	30	21	10
		getState	4	70	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1000	1567	1146	119	57
		setupStore	7	49	11	9	4
		uiStartup	1650	2407	1851	206	99

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -567 Bytes (-0.01%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-18T19:43:48Z

Builds ready [56f0a87]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1626 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1449	1861	1638	114	55
		domContentLoaded	1407	1847	1601	116	56
		load	1448	1862	1626	113	54
		domInteractive	24	81	34	15	7
		backgroundConnect	9	76	27	19	9
		firstReactRender	14	93	29	24	11
		getState	4	54	21	18	9
		initialActions	0	1	0	0	0
		loadScripts	989	1380	1156	105	50
		setupStore	7	70	19	19	9
		uiStartup	1670	2225	1912	155	74

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -567 Bytes (-0.01%)
common: 0 Bytes (0.00%)

ui/pages/snap-account-redirect/components/url-display-box.tsx

ui/pages/snap-account-redirect/components/snap-account-redirect-context.tsx

metamaskbot · 2025-02-19T00:33:49Z

Builds ready [ad2f2d2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1658 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	231	1854	1598	328	158
		domContentLoaded	1469	1835	1635	100	48
		load	1473	1901	1658	105	50
		domInteractive	24	105	42	24	11
		backgroundConnect	10	73	30	20	10
		firstReactRender	14	99	40	27	13
		getState	5	53	13	13	6
		initialActions	0	0	0	0	0
		loadScripts	1048	1358	1183	94	45
		setupStore	7	100	22	25	12
		uiStartup	1701	2498	1933	176	85

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -567 Bytes (-0.01%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-19T17:33:17Z

Builds ready [2c740db]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1601 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	393	1757	1540	280	134
		domContentLoaded	1409	1691	1579	86	41
		load	1417	1761	1601	96	46
		domInteractive	23	104	46	27	13
		backgroundConnect	7	89	28	25	12
		firstReactRender	14	80	40	25	12
		getState	4	53	16	17	8
		initialActions	0	1	0	0	0
		loadScripts	968	1266	1145	80	39
		setupStore	7	61	11	12	6
		uiStartup	1584	2191	1828	139	67

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -567 Bytes (-0.01%)
common: 0 Bytes (0.00%)

DDDDDanica · 2025-02-19T21:40:04Z

LGTM !

metamaskbot · 2025-02-19T21:59:19Z

Builds ready [9d4e699]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1845 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1673	2241	1845	172	82
		domContentLoaded	1631	2225	1818	173	83
		load	1635	2245	1845	174	84
		domInteractive	28	110	40	22	10
		backgroundConnect	8	74	34	19	9
		firstReactRender	15	76	37	25	12
		getState	5	70	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	1162	1670	1320	151	72
		setupStore	8	59	18	17	8
		uiStartup	1906	2649	2119	223	107

Bundle size diffs

background: 0 Bytes (0.00%)
ui: -567 Bytes (-0.01%)
common: 0 Bytes (0.00%)

refactor: remove circular dependencies in `ui/pages/snap-account-redi…

96620db

…rect/*`

metamaskbot added the team-extension-platform Extension Platform team label Feb 12, 2025

Merge branch 'main' into circles-snap-account

c27dc0b

davidmurdoch marked this pull request as ready for review February 13, 2025 00:09

davidmurdoch requested review from HowardBraham, dbrans and a team as code owners February 13, 2025 00:09

HowardBraham previously approved these changes Feb 13, 2025

View reviewed changes

gauthierpetetin assigned davidmurdoch Feb 13, 2025

Merge branch 'main' into circles-snap-account

7197c34

davidmurdoch enabled auto-merge February 14, 2025 17:57

Merge branch 'main' into circles-snap-account

56f0a87

Merge branch 'main' into circles-snap-account

ad2f2d2

DDDDDanica reviewed Feb 19, 2025

View reviewed changes

ui/pages/snap-account-redirect/components/url-display-box.tsx Outdated Show resolved Hide resolved

DDDDDanica reviewed Feb 19, 2025

View reviewed changes

ui/pages/snap-account-redirect/components/snap-account-redirect-context.tsx Outdated Show resolved Hide resolved

davidmurdoch requested a review from DDDDDanica February 19, 2025 16:57

move type keyword over

2c740db

davidmurdoch dismissed HowardBraham’s stale review via 2c740db February 19, 2025 16:57

davidmurdoch requested a review from HowardBraham February 19, 2025 16:57

HowardBraham previously approved these changes Feb 19, 2025

View reviewed changes

Merge branch 'main' into circles-snap-account

9d4e699

davidmurdoch dismissed HowardBraham’s stale review via 9d4e699 February 19, 2025 21:20

DDDDDanica approved these changes Feb 19, 2025

View reviewed changes

davidmurdoch requested a review from HowardBraham February 19, 2025 21:55

HowardBraham approved these changes Feb 19, 2025

View reviewed changes

davidmurdoch added this pull request to the merge queue Feb 19, 2025

Merged via the queue into main with commit 7b03791 Feb 19, 2025
79 checks passed

davidmurdoch deleted the circles-snap-account branch February 19, 2025 22:42

github-actions bot locked and limited conversation to collaborators Feb 19, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove circular dependencies in `ui/pages/snap-account-redirect/*` #30279

refactor: remove circular dependencies in `ui/pages/snap-account-redirect/*` #30279

davidmurdoch commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 13, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

DDDDDanica commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

refactor: remove circular dependencies in ui/pages/snap-account-redirect/* #30279

refactor: remove circular dependencies in ui/pages/snap-account-redirect/* #30279

Conversation

davidmurdoch commented Feb 12, 2025 • edited Loading

github-actions bot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 13, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

DDDDDanica commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

refactor: remove circular dependencies in `ui/pages/snap-account-redirect/*` #30279

refactor: remove circular dependencies in `ui/pages/snap-account-redirect/*` #30279

davidmurdoch commented Feb 12, 2025 •

edited

Loading