Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update slides descriptions #30270

Merged
merged 4 commits into from
Feb 18, 2025
Merged

feat: update slides descriptions #30270

merged 4 commits into from
Feb 18, 2025

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Feb 12, 2025

Description

Replace current copy description for "Fund your wallet" carousel banner to "Add or transfer tokens to get started".
Replace current copy description for "MetaMask Card" carousel banner to "Available in select regions".

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/metamask-mobile#13021

Manual testing steps

  1. Go to the main wallet page
  2. Check that the slides show the new descriptions

Screenshots/Recordings

Before

After

Image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [029461a]
Page Load Metrics (1488 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1393166814957034
domContentLoaded1385165614656330
load1393166614886832
domInteractive2078452311
backgroundConnect96525189
firstReactRender1474392512
getState441984
initialActions01000
loadScripts983124410636029
setupStore74512115
uiStartup1574192516919445
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 8 Bytes (0.00%)

vinnyhoward
vinnyhoward previously approved these changes Feb 13, 2025
NidhiKJha
NidhiKJha previously approved these changes Feb 13, 2025
@jonybur jonybur added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@jonybur jonybur added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@jonybur jonybur dismissed stale reviews from NidhiKJha and vinnyhoward via 42a3785 February 17, 2025 14:39
NidhiKJha
NidhiKJha previously approved these changes Feb 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [053ae1a]
Page Load Metrics (1574 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14251874157410752
domContentLoaded14181865155210550
load14261877157410751
domInteractive2393432010
backgroundConnect9101232411
firstReactRender1372312311
getState481192211
initialActions01000
loadScripts1014136611229345
setupStore67516199
uiStartup16322258181316177
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 8 Bytes (0.00%)

@jonybur jonybur enabled auto-merge February 18, 2025 15:55
@jonybur jonybur added this pull request to the merge queue Feb 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4227d8d]
Page Load Metrics (1661 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24019661513442212
domContentLoaded14301951163913565
load14712011166114168
domInteractive2497402110
backgroundConnect86727189
firstReactRender1370302210
getState46115178
initialActions01000
loadScripts9941423117011053
setupStore76315147
uiStartup16832295190315273
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 8 Bytes (0.00%)

Merged via the queue into main with commit 8746cf3 Feb 18, 2025
73 checks passed
@jonybur jonybur deleted the update-carousel-copy branch February 18, 2025 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copy for "Fund your wallet" and "MetaMask Card" carousel banners
4 participants