Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add integration test to check nonce editing is disabled when stx is on #30260

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Feb 12, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: #4183

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 12, 2025
@pnarayanaswamy pnarayanaswamy marked this pull request as ready for review February 12, 2025 10:17
@metamaskbot
Copy link
Collaborator

Builds ready [146299c]
Page Load Metrics (1639 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21818921571344165
domContentLoaded14211869160813766
load14411888163915273
domInteractive248037168
backgroundConnect9129343215
firstReactRender16100352512
getState460202010
initialActions01000
loadScripts10011438116912058
setupStore774192010
uiStartup162226051905231111
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit f7690e3 Feb 12, 2025
76 checks passed
@pnarayanaswamy pnarayanaswamy deleted the test-stx-nonce branch February 12, 2025 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants