Update LavaMoat policies

MetaMask · Jan 15, 2025 · 704d4ab · 704d4ab
1 parent ced7bf4
commit 704d4ab
Show file tree

Hide file tree

Showing 9 changed files with 99 additions and 276 deletions.
diff --git a/development/webpack/test/webpack.config.test.ts b/development/webpack/test/webpack.config.test.ts
@@ -78,7 +78,7 @@ ${Object.entries(env)
   }
 
   it('should have the correct defaults', () => {
-    const config: Configuration = getWebpackConfig();
+    const config: Configuration = getWebpackConfig(['--test']);
     // check that options are valid
     const { options } = webpack(config);
     assert.strictEqual(options.name, 'MetaMask – development');
@@ -162,6 +162,9 @@ ${Object.entries(env)
       {
         manifest_version: 3,
         name: 'name',
+        permissions: [
+          'tabs'
+        ],
         version: '1.2.3',
         content_scripts: [
           {
@@ -191,6 +194,7 @@ ${Object.entries(env)
         '--no-progress',
         '--no-cache',
         '--zip',
+        '--test',
         ...removeUnsupportedFeatures,
       ],
       {
@@ -231,7 +235,7 @@ ${Object.entries(env)
     assert.deepStrictEqual(manifestPlugin.options.description, null);
     assert.deepStrictEqual(manifestPlugin.options.zip, true);
     assert(manifestPlugin.options.zipOptions, 'Zip options should be present');
-    assert.strictEqual(manifestPlugin.options.transform, undefined);
+    assert.notEqual(manifestPlugin.options.transform, undefined);
 
     const progressPlugin = instance.options.plugins.find(
       (plugin) => plugin && plugin.constructor.name === 'ProgressPlugin',

diff --git a/development/webpack/utils/plugins/ManifestPlugin/helpers.ts b/development/webpack/utils/plugins/ManifestPlugin/helpers.ts
@@ -35,7 +35,10 @@ export function transformManifest(args: { lockdown: boolean; test: boolean }) {
     browserManifest._flags = manifestFlags;
   }
 
-  transforms.push(addManifestFlags);
+  // Add manifest flags only for non-test builds so the test build is not affected by local feature flags
+  if(!args.test) {
+    transforms.push(addManifestFlags);
+  }
 
   if (!args.lockdown) {
     // remove lockdown scripts from content_scripts

diff --git a/lavamoat/browserify/beta/policy.json b/lavamoat/browserify/beta/policy.json
@@ -5650,4 +5650,4 @@
       }
     }
   }
-}
+}
diff --git a/lavamoat/browserify/flask/policy.json b/lavamoat/browserify/flask/policy.json
@@ -5650,4 +5650,4 @@
       }
     }
   }
-}
+}
diff --git a/lavamoat/browserify/main/policy.json b/lavamoat/browserify/main/policy.json
@@ -5650,4 +5650,4 @@
       }
     }
   }
-}
+}
diff --git a/lavamoat/browserify/mmi/policy.json b/lavamoat/browserify/mmi/policy.json
@@ -5742,4 +5742,4 @@
       }
     }
   }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -5650,4 +5650,4 @@ @@
           }
         }
       }
-    }
+    }