generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding avatar network to design system react #409
Draft
georgewrmarshall
wants to merge
4
commits into
main
Choose a base branch
from
feat/366/dsr-avatar-network
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/design-system-react/src/components/avatar-network/AvatarNetwork.constants.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+11
to
+12
[AvatarBaseSize.Xs]: TextVariant.BodyXs, | ||
[AvatarBaseSize.Sm]: TextVariant.BodyXs, | ||
[AvatarBaseSize.Md]: TextVariant.BodySm, | ||
[AvatarBaseSize.Lg]: TextVariant.BodyMd, | ||
[AvatarBaseSize.Xl]: TextVariant.BodyMd, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent a circular dependency we export AvatarBaseSize
as AvatarNetworkSize
but use AvatarBaseSize
internally.
packages/design-system-react/src/components/avatar-network/AvatarNetwork.stories.tsx
Outdated
Show resolved
Hide resolved
packages/design-system-react/src/components/avatar-network/AvatarNetwork.stories.tsx
Outdated
Show resolved
Hide resolved
packages/design-system-react/src/components/avatar-network/AvatarNetwork.test.tsx
Outdated
Show resolved
Hide resolved
packages/design-system-react/src/components/avatar-network/AvatarNetwork.test.tsx
Outdated
Show resolved
Hide resolved
georgewrmarshall
force-pushed
the
feat/366/dsr-avatar-network
branch
from
January 30, 2025 23:57
35ece8d
to
6a0edfb
Compare
Comment on lines
63
to
66
/** | ||
* Optional prop to pass to the underlying HTML element | ||
*/ | ||
'data-testid'?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
georgewrmarshall
force-pushed
the
feat/366/dsr-avatar-network
branch
2 times, most recently
from
January 31, 2025 00:09
befddee
to
e52f356
Compare
7 tasks
georgewrmarshall
force-pushed
the
feat/366/dsr-avatar-network
branch
3 times, most recently
from
January 31, 2025 01:23
58f1ffc
to
142579e
Compare
georgewrmarshall
force-pushed
the
feat/366/dsr-avatar-network
branch
from
January 31, 2025 01:27
142579e
to
d4e6d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has a dependency on #390
Description
This PR adds the initial
AvatarNetwork
component to design system reactKey features:
Related issues
Fixes: #366
Manual testing steps
Screenshots/Recordings
Before
N/A - New component
After
after720.mov
Pre-merge author checklist
Pre-merge reviewer checklist