Decryption using shared secret support for hardware wallet #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasALLOIN
force-pushed
the
decrytion-using-shared-secret-support
branch
from
67985b4 to
fc62c88
Compare
|
Hello @Gudahtt sorry for pinging you, but looks like you are one of the main maintainer of this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there !
I've implemented decryptWithSharedSecret function that allow to decrypt encrypted data with an shared secret (that will allow to compute ephemeral private key) rather than the private key itself.
This will be really helpfull for hardware wallet operation (you ask the hardaware wallet the shared secret and decrypt locally) because hadware wallet does not provide access to private key to decrypt data and are to rudimentary to process the decryption by itself.
This PR will permit me to finish EIP1024 decryption for ledger keyring (https://github.com/MetaMask/eth-ledger-bridge-keyring/)
Thanks you & ask anything you want !