Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export controller messenger type to index #5296

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Bigshmow
Copy link
Contributor

@Bigshmow Bigshmow commented Feb 6, 2025

Explanation

We are not explicitly exporting the TokenSearchDiscoveryControllerMessenger type from package index and therefor consumers are forced to import from the common js module.

References

Needed to resolve a comment in related to these types of imports: MetaMask/metamask-mobile#13111

Changelog

@metamask/token-search-discovery-controller

  • Added: export TokenSearchDiscoveryControllerMessenger type from index

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Bigshmow Bigshmow marked this pull request as ready for review February 6, 2025 18:10
@Bigshmow Bigshmow requested review from a team as code owners February 6, 2025 18:10
@Bigshmow Bigshmow merged commit 4b48b6a into main Feb 6, 2025
130 checks passed
@Bigshmow Bigshmow deleted the chore-add-messenger-to-index-as-an-export branch February 6, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants