-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support type 4 transactions #5285
Conversation
Create prepare utils.
Add initial unit tests.
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore-all |
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
Explanation
Support EIP-7702 / type 4 transactions including
authorizationList
via theTransactionController
.Specifically:
ethereumjs/tx
andethereumjs/common
.setCode
toTransactionEnvelopeType
.authorizationList
toTransactionParams
.KeyringController
before signing transaction.ORIGIN_METAMASK
.authorizationList
property before approval request.prepare.ts
utils.eip7702.ts
util.Currently using a local messenger action type for the signing. To be replaced once available in the
KeyringController
.References
Fixes #4095
Changelog
@metamask/transaction-controller
setCode
toTransactionEnvelopeType
.authorizationList
toTransactionParams
.ethereumjs/tx
to^5.4.0
.ethereumjs/common
to^4.4.0
.Checklist