-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failover support to RpcService #5202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
add-failover-support-to-nc-rpc-service
branch
3 times, most recently
from
January 27, 2025 22:20
8a973c8
to
3abe368
Compare
@metamaskbot publish-previews |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
mcmire
force-pushed
the
add-failover-support-to-nc-rpc-service
branch
from
January 29, 2025 20:39
3abe368
to
357210d
Compare
mcmire
force-pushed
the
add-failover-support-to-nc-rpc-service
branch
from
January 30, 2025 15:47
b24e8e7
to
2448daf
Compare
Add a new `failoverService` option to RpcService. This allows consumers to forward the request to another RPC service in the event that an RPC endpoint is proven to be unreliable (i.e. after attempting the request 5 times, the endpoint is unreachable, returns a a non-200 response, or returns a response that is not JSON-decodable).
mcmire
force-pushed
the
add-failover-support-to-nc-rpc-service
branch
from
January 30, 2025 15:48
2448daf
to
44f59ab
Compare
mikesposito
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add a new
failoverService
option to RpcService. This allows consumers to forward the request to another RPC service in the event that an RPC endpoint is proven to be unreliable (i.e. after attempting the request 5 times, the endpoint is unreachable, returns a a non-200 response, or returns a response that is not JSON-decodable).References
Closes #4992.
Changelog
(N/A; RpcService is not public yet so no changelog updates)
Checklist