Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support transactions from account snaps that should not be published #5045

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Support transactions from account snaps that should not be published #5045

wants to merge 14 commits into from

Conversation

shane-t
Copy link
Member

@shane-t shane-t commented Dec 9, 2024 •
edited
Loading

Explanation

Relates to this extension PR

Should not be merged; this is a demonstration

References

TBD

Changelog

@metamask/transaction-controller

  • CHANGED: Removed coupling of "Update custodial transactions" and MMI
  • ADDED: Before publish hook now receives raw transaction

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@shane-t shane-t force-pushed the MMI-5803-deferral-proposal-2 branch from 2f7ffb1 to e58ce4a Compare December 9, 2024 19:49
@shane-t
Copy link
Member Author

shane-t commented Dec 9, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "20.0.0-preview-e58ce4ab",
  "@metamask-previews/address-book-controller": "6.0.1-preview-e58ce4ab",
  "@metamask-previews/announcement-controller": "7.0.1-preview-e58ce4ab",
  "@metamask-previews/approval-controller": "7.1.1-preview-e58ce4ab",
  "@metamask-previews/assets-controllers": "45.1.0-preview-e58ce4ab",
  "@metamask-previews/base-controller": "7.0.2-preview-e58ce4ab",
  "@metamask-previews/build-utils": "3.0.1-preview-e58ce4ab",
  "@metamask-previews/chain-controller": "0.2.0-preview-e58ce4ab",
  "@metamask-previews/composable-controller": "9.0.1-preview-e58ce4ab",
  "@metamask-previews/controller-utils": "11.4.3-preview-e58ce4ab",
  "@metamask-previews/ens-controller": "15.0.0-preview-e58ce4ab",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-e58ce4ab",
  "@metamask-previews/gas-fee-controller": "22.0.1-preview-e58ce4ab",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-e58ce4ab",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-e58ce4ab",
  "@metamask-previews/keyring-controller": "19.0.0-preview-e58ce4ab",
  "@metamask-previews/logging-controller": "6.0.2-preview-e58ce4ab",
  "@metamask-previews/message-manager": "11.0.1-preview-e58ce4ab",
  "@metamask-previews/multichain": "1.0.0-preview-e58ce4ab",
  "@metamask-previews/name-controller": "8.0.1-preview-e58ce4ab",
  "@metamask-previews/network-controller": "22.0.2-preview-e58ce4ab",
  "@metamask-previews/notification-controller": "7.0.0-preview-e58ce4ab",
  "@metamask-previews/notification-services-controller": "0.14.0-preview-e58ce4ab",
  "@metamask-previews/permission-controller": "11.0.3-preview-e58ce4ab",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-e58ce4ab",
  "@metamask-previews/phishing-controller": "12.3.0-preview-e58ce4ab",
  "@metamask-previews/polling-controller": "12.0.1-preview-e58ce4ab",
  "@metamask-previews/preferences-controller": "15.0.0-preview-e58ce4ab",
  "@metamask-previews/profile-sync-controller": "2.0.0-preview-e58ce4ab",
  "@metamask-previews/queued-request-controller": "8.0.0-preview-e58ce4ab",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-e58ce4ab",
  "@metamask-previews/selected-network-controller": "20.0.0-preview-e58ce4ab",
  "@metamask-previews/signature-controller": "23.0.0-preview-e58ce4ab",
  "@metamask-previews/transaction-controller": "41.0.0-preview-e58ce4ab",
  "@metamask-previews/user-operation-controller": "20.0.0-preview-e58ce4ab"
}

@shane-t shane-t marked this pull request as ready for review January 28, 2025 09:50
@shane-t shane-t requested a review from a team as a code owner January 28, 2025 09:50
@shane-t
Copy link
Member Author

shane-t commented Feb 5, 2025

@metamaskbot publish-preview

@shane-t
Copy link
Member Author

shane-t commented Feb 6, 2025

@metamaskbot publish-preview

@shane-t
Copy link
Member Author

shane-t commented Feb 6, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "23.0.0-preview-83e41399",
  "@metamask-previews/address-book-controller": "6.0.2-preview-83e41399",
  "@metamask-previews/announcement-controller": "7.0.2-preview-83e41399",
  "@metamask-previews/approval-controller": "7.1.2-preview-83e41399",
  "@metamask-previews/assets-controllers": "48.0.0-preview-83e41399",
  "@metamask-previews/base-controller": "7.1.1-preview-83e41399",
  "@metamask-previews/build-utils": "3.0.2-preview-83e41399",
  "@metamask-previews/composable-controller": "10.0.0-preview-83e41399",
  "@metamask-previews/controller-utils": "11.5.0-preview-83e41399",
  "@metamask-previews/earn-controller": "0.2.0-preview-83e41399",
  "@metamask-previews/ens-controller": "15.0.1-preview-83e41399",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-83e41399",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-83e41399",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-83e41399",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-83e41399",
  "@metamask-previews/keyring-controller": "19.0.6-preview-83e41399",
  "@metamask-previews/logging-controller": "6.0.3-preview-83e41399",
  "@metamask-previews/message-manager": "12.0.0-preview-83e41399",
  "@metamask-previews/multichain": "2.1.0-preview-83e41399",
  "@metamask-previews/multichain-transactions-controller": "0.2.0-preview-83e41399",
  "@metamask-previews/name-controller": "8.0.2-preview-83e41399",
  "@metamask-previews/network-controller": "22.2.0-preview-83e41399",
  "@metamask-previews/notification-services-controller": "0.20.0-preview-83e41399",
  "@metamask-previews/permission-controller": "11.0.5-preview-83e41399",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-83e41399",
  "@metamask-previews/phishing-controller": "12.3.1-preview-83e41399",
  "@metamask-previews/polling-controller": "12.0.2-preview-83e41399",
  "@metamask-previews/preferences-controller": "15.0.1-preview-83e41399",
  "@metamask-previews/profile-sync-controller": "7.0.0-preview-83e41399",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-83e41399",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-83e41399",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-83e41399",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-83e41399",
  "@metamask-previews/signature-controller": "23.2.0-preview-83e41399",
  "@metamask-previews/token-search-discovery-controller": "2.0.0-preview-83e41399",
  "@metamask-previews/transaction-controller": "45.0.0-preview-83e41399",
  "@metamask-previews/user-operation-controller": "24.0.0-preview-83e41399"
}

@shane-t
Copy link
Member Author

shane-t commented Feb 6, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "23.0.0-preview-224dff25",
  "@metamask-previews/address-book-controller": "6.0.2-preview-224dff25",
  "@metamask-previews/announcement-controller": "7.0.2-preview-224dff25",
  "@metamask-previews/approval-controller": "7.1.2-preview-224dff25",
  "@metamask-previews/assets-controllers": "48.0.0-preview-224dff25",
  "@metamask-previews/base-controller": "7.1.1-preview-224dff25",
  "@metamask-previews/build-utils": "3.0.2-preview-224dff25",
  "@metamask-previews/composable-controller": "10.0.0-preview-224dff25",
  "@metamask-previews/controller-utils": "11.5.0-preview-224dff25",
  "@metamask-previews/earn-controller": "0.2.0-preview-224dff25",
  "@metamask-previews/ens-controller": "15.0.1-preview-224dff25",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-224dff25",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-224dff25",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-224dff25",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-224dff25",
  "@metamask-previews/keyring-controller": "19.0.6-preview-224dff25",
  "@metamask-previews/logging-controller": "6.0.3-preview-224dff25",
  "@metamask-previews/message-manager": "12.0.0-preview-224dff25",
  "@metamask-previews/multichain": "2.1.0-preview-224dff25",
  "@metamask-previews/multichain-transactions-controller": "0.2.0-preview-224dff25",
  "@metamask-previews/name-controller": "8.0.2-preview-224dff25",
  "@metamask-previews/network-controller": "22.2.0-preview-224dff25",
  "@metamask-previews/notification-services-controller": "0.20.0-preview-224dff25",
  "@metamask-previews/permission-controller": "11.0.5-preview-224dff25",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-224dff25",
  "@metamask-previews/phishing-controller": "12.3.1-preview-224dff25",
  "@metamask-previews/polling-controller": "12.0.2-preview-224dff25",
  "@metamask-previews/preferences-controller": "15.0.1-preview-224dff25",
  "@metamask-previews/profile-sync-controller": "7.0.0-preview-224dff25",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-224dff25",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-224dff25",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-224dff25",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-224dff25",
  "@metamask-previews/signature-controller": "23.2.0-preview-224dff25",
  "@metamask-previews/token-search-discovery-controller": "2.0.0-preview-224dff25",
  "@metamask-previews/transaction-controller": "45.0.0-preview-224dff25",
  "@metamask-previews/user-operation-controller": "24.0.0-preview-224dff25"
}

@shane-t shane-t requested a review from a team as a code owner February 6, 2025 16:39
@shane-t
Copy link
Member Author

shane-t commented Feb 20, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "24.0.0-preview-1cc9329c",
  "@metamask-previews/address-book-controller": "6.0.3-preview-1cc9329c",
  "@metamask-previews/announcement-controller": "7.0.3-preview-1cc9329c",
  "@metamask-previews/approval-controller": "7.1.3-preview-1cc9329c",
  "@metamask-previews/assets-controllers": "51.0.0-preview-1cc9329c",
  "@metamask-previews/base-controller": "8.0.0-preview-1cc9329c",
  "@metamask-previews/bridge-controller": "0.0.0-preview-1cc9329c",
  "@metamask-previews/build-utils": "3.0.3-preview-1cc9329c",
  "@metamask-previews/composable-controller": "11.0.0-preview-1cc9329c",
  "@metamask-previews/controller-utils": "11.5.0-preview-1cc9329c",
  "@metamask-previews/earn-controller": "0.4.0-preview-1cc9329c",
  "@metamask-previews/ens-controller": "15.0.2-preview-1cc9329c",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-1cc9329c",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-1cc9329c",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-1cc9329c",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-1cc9329c",
  "@metamask-previews/keyring-controller": "19.2.0-preview-1cc9329c",
  "@metamask-previews/logging-controller": "6.0.4-preview-1cc9329c",
  "@metamask-previews/message-manager": "12.0.1-preview-1cc9329c",
  "@metamask-previews/multichain": "2.1.1-preview-1cc9329c",
  "@metamask-previews/multichain-network-controller": "0.1.1-preview-1cc9329c",
  "@metamask-previews/multichain-transactions-controller": "0.4.0-preview-1cc9329c",
  "@metamask-previews/name-controller": "8.0.3-preview-1cc9329c",
  "@metamask-previews/network-controller": "22.2.1-preview-1cc9329c",
  "@metamask-previews/notification-services-controller": "0.21.0-preview-1cc9329c",
  "@metamask-previews/permission-controller": "11.0.6-preview-1cc9329c",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-1cc9329c",
  "@metamask-previews/phishing-controller": "12.3.2-preview-1cc9329c",
  "@metamask-previews/polling-controller": "12.0.3-preview-1cc9329c",
  "@metamask-previews/preferences-controller": "15.0.2-preview-1cc9329c",
  "@metamask-previews/profile-sync-controller": "8.1.0-preview-1cc9329c",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-1cc9329c",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-1cc9329c",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-1cc9329c",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-1cc9329c",
  "@metamask-previews/signature-controller": "23.2.1-preview-1cc9329c",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-1cc9329c",
  "@metamask-previews/transaction-controller": "46.0.0-preview-1cc9329c",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-1cc9329c"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shane-t