Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Solana methods from wallet-standard #189

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add Solana methods from wallet-standard #189

wants to merge 2 commits into from

Conversation

aganglada
Copy link

This change adds support for Solana wallet standard methods and removes the previous ones

Examples

@aganglada aganglada self-assigned this Feb 3, 2025
@aganglada aganglada requested a review from a team as a code owner February 3, 2025 14:30
@aganglada aganglada requested review from ccharly and danroc February 3, 2025 14:30
@danroc
Copy link
Contributor

danroc commented Feb 4, 2025

@aganglada, is the solana: prefix present in the requests sent by dapps? If not, the RPC Router won't be able to send them to the right Snap.

@aganglada aganglada marked this pull request as draft February 6, 2025 10:54
@danroc danroc changed the title feat: solana methods to support wallet standard methods feat: add Solana methods from wallet-standard Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly Awaiting requested review from ccharly

@danroc danroc Awaiting requested review from danroc

At least 1 approving review is required to merge this pull request.

Assignees

@aganglada aganglada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aganglada @danroc