Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove HdKeyring as default export #161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor!: remove HdKeyring as default export #161

wants to merge 2 commits into from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jan 27, 2025 •
edited
Loading

After @metamask/eth-hd-keyring is migrated to Typescript, this PR edits its main file name and removes HdKeyeing as default export.

The number of line changes in the GitHub diff is misleading; the PR mostly renames index.ts into hd-keyring.ts and adds a new index.ts file which exports the hd-keyring.ts file contents

### Changed

- **BREAKING:** The `HdKeyring` is not exported as default anymore ([#161](https://github.com/MetaMask/accounts/pull/161))

@mikesposito mikesposito changed the title wip: Migrate HdKeyring to typescript refactor: Migrate HdKeyring to typescript Jan 28, 2025
@mikesposito mikesposito changed the title refactor: Migrate HdKeyring to typescript refactor!: Migrate HdKeyring to typescript Jan 28, 2025
@mikesposito mikesposito changed the title refactor!: Migrate HdKeyring to typescript refactor!: migrate HdKeyring to typescript Jan 28, 2025
@mikesposito mikesposito marked this pull request as ready for review January 28, 2025 14:35
@mikesposito mikesposito requested a review from a team as a code owner January 28, 2025 14:35
@mikesposito
Copy link
Member Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "15.0.0-0aca2ee",
  "@metamask-previews/eth-hd-keyring": "9.0.1-0aca2ee",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.3-0aca2ee",
  "@metamask-previews/eth-simple-keyring": "8.0.1-0aca2ee",
  "@metamask-previews/eth-trezor-keyring": "6.0.1-0aca2ee",
  "@metamask-previews/keyring-internal-api": "3.0.0-0aca2ee",
  "@metamask-previews/keyring-internal-snap-client": "3.0.1-0aca2ee",
  "@metamask-previews/eth-snap-keyring": "9.0.0-0aca2ee",
  "@metamask-previews/keyring-snap-client": "3.0.1-0aca2ee",
  "@metamask-previews/keyring-snap-sdk": "2.1.0-0aca2ee",
  "@metamask-previews/keyring-utils": "1.3.0-0aca2ee"
}

@mikesposito mikesposito mentioned this pull request Jan 28, 2025
Merged
@mikesposito mikesposito changed the base branch from main to mikesposito/hdkeyring-ts-only January 28, 2025 15:20
@mikesposito mikesposito marked this pull request as draft January 28, 2025 15:21
@mikesposito mikesposito changed the title refactor!: migrate HdKeyring to typescript refactor!: remove HdKeyring as default export Jan 28, 2025
@mikesposito mikesposito force-pushed the mikesposito/hdkeyring-typescript branch from 0aca2ee to aa7ef4d Compare January 28, 2025 15:51
Base automatically changed from mikesposito/hdkeyring-ts-only to main February 4, 2025 12:48
@mikesposito mikesposito force-pushed the mikesposito/hdkeyring-typescript branch from 1e0dfc2 to 2798c66 Compare February 5, 2025 14:06
@mikesposito mikesposito marked this pull request as ready for review February 5, 2025 14:11
mikesposito
mikesposito commented Feb 5, 2025
View reviewed changes
packages/keyring-eth-hd/src/hd-keyring.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has only been renamed from index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s Awaiting requested review from cryptodev-2s

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @cryptodev-2s