Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LPC1768 OR LPC1769 capability for board that can have either #27586

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Dec 13, 2024

Description

It was discovered that some boards can have either a LPC1768 or LPC1769
In particular a MKS_SBASE was just recently found in the wild with a LPC1769

mks_sbase_lpc1769

When looking into this I also noticed that the SMOOTHIEBOARD also didn't accept LPC1768 or LPC1769 and I know from personal experience this board can have either

Before someone says what about the BTT_SKR_V1_4, it has LPC1768 and LPC1769
No it doesnt
BTT_SKR_V1_4 is LPC1768 while BTT_SKR_V1_4_TURBO is LPC1769

Requirements

SMOOTHIEBOARD or MKS_SBASE board with either LPC1768 or LPC1769

Benefits

Builds as expected

Related Issues

https://discord.com/channels/461605380783472640/1315708058353143939/1316814832502050836

@ellensp ellensp added this to the Version 2.1.3 milestone Dec 13, 2024
@thisiskeithb
Copy link
Member

I wonder if this is tied to newer SBASE board versions, but that's the problem we run into when we're not precise with those while adding boards 😄

@thinkyhead thinkyhead force-pushed the can-be-either-lpc1768-or-lpc1769 branch from 4ae4d93 to 354b08c Compare January 8, 2025 22:32
@thinkyhead thinkyhead force-pushed the can-be-either-lpc1768-or-lpc1769 branch from 354b08c to ab42819 Compare January 8, 2025 22:38
@thinkyhead thinkyhead merged commit 375deac into MarlinFirmware:bugfix-2.1.x Jan 8, 2025
65 checks passed
@ellensp ellensp deleted the can-be-either-lpc1768-or-lpc1769 branch January 9, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants