Add a spec verifying all providers have a matching vendor asset #23372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit Fryguy@7f3f25f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.59.0, and yamllint |
agrare
reviewed
Mar 8, 2025
|
@agrare the three failures match what I saw locally, and I wasn't sure if they were legit or were a misconfiguration or copy paste error.
|
|
Monitoring isn't supported for create there just aren't any providers of that type (Prometheus Alert Monitor was the only one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agrare Please review. I chose concrete_subclasses, and there are 3 that are missing images. Is that the right choice, or should I use supported_types_for_create. I thought the former was better because even if we can't create it, it can still appear and might need an image.
Follow up to ManageIQ/manageiq-ui-classic#9355
cc @jrafanie